Repository navigation
Commit 826da07
Validate each branch against its own commits on retry (apache#4317)
* Assert every ref a transaction writes, not just the first
Transaction._stage de-duplicated requirements by type, so a transaction
writing two branches only sent AssertRefSnapshotId for the first one and
a concurrent change to the second was overwritten. Key ref assertions by
ref name so each ref keeps its base assertion, as Java does.
Closes apache#4183
* Validate each branch against its own commits on retry
The retry path and the empty-output validation path resolved one
CommitWindow from the first snapshot producer and reused it for every
producer, so in a multi-branch transaction a delete or overwrite on a
later branch was validated against the first branch's commits and could
skip validation entirely. Resolve one window per target branch, based on
the first producer on that branch, since later producers on the same
branch start from a snapshot staged by this transaction.
Closes apache#4316
---------
Co-authored-by: Fokko Driesprong <[email protected]>1 parent 8e1f4a3 commit 826da07
2 files changed
Lines changed: 86 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1197 | 1197 | | |
1198 | 1198 | | |
1199 | 1199 | | |
1200 | | - | |
1201 | | - | |
1202 | 1200 | | |
1203 | 1201 | | |
1204 | | - | |
1205 | | - | |
1206 | | - | |
1207 | | - | |
1208 | | - | |
| 1202 | + | |
1209 | 1203 | | |
1210 | | - | |
1211 | 1204 | | |
1212 | 1205 | | |
1213 | 1206 | | |
| |||
1245 | 1238 | | |
1246 | 1239 | | |
1247 | 1240 | | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
1248 | 1256 | | |
1249 | 1257 | | |
1250 | 1258 | | |
1251 | | - | |
1252 | 1259 | | |
1253 | 1260 | | |
1254 | 1261 | | |
1255 | 1262 | | |
1256 | | - | |
1257 | | - | |
1258 | | - | |
1259 | | - | |
| 1263 | + | |
1260 | 1264 | | |
1261 | | - | |
1262 | 1265 | | |
1263 | 1266 | | |
1264 | 1267 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1493 | 1493 | | |
1494 | 1494 | | |
1495 | 1495 | | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
| 1534 | + | |
| 1535 | + | |
| 1536 | + | |
| 1537 | + | |
| 1538 | + | |
| 1539 | + | |
| 1540 | + | |
| 1541 | + | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
| 1545 | + | |
| 1546 | + | |
| 1547 | + | |
| 1548 | + | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
| 1563 | + | |
| 1564 | + | |
0 commit comments