Merged
Conversation
it also propagates changes made to settings in Dynamo
- renamed static prop to PublicPreferenceSettings, essentially adding `Public` in front of existing field - added lines to update the static prop where the `PreferenceSettings` gets updated in the model - set static prop to be public GET, private SET - tested with build, changes are picked up by Python nodes just fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Added a
publicstaticproperty calledPublicPreferenceSettingstoDynamoModelclass, so that nodes and other components that are not fully aware of the context they're executed in can still access these properties.The property should be thread-safe as it's read-only :
publicaccessprivateaccessAlso added lines to update the static property whenever the instance-based
PreferenceSettingsgets updated within theDynamoModelclass.Tested by
DynamoSandboxshow connectorsor adding a new custom package path)Declarations
Check these if you believe they are true
*.resxfilesReviewers
@radumg
FYIs