You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f4bcebf
Browse filesBrowse the repository at this point in the historyBrowse files
fix(t3x): stop a user message destroying a pending auto-resume
Closes#39.
Two defects compounded into a permanently stranded thread: a usage limit
armed a resume, the user typed "keep going" at the banner, that message
was itself rejected so it started nothing, and the wake tick then threw
the arm away as `user-took-over`. Net pending afterwards: zero. Measured
on the reporting install at 4 of 17 armed resumes (~24%) since #6.
1. `guards.ts` — drop the `user-took-over` branch. It is the same
negative-evidence mistake #6 fixed on the line below it: "a message
exists that wasn't there when we armed" is not evidence the human took
the wheel, and in practice it is the opposite signal. Everything the
branch reached for is still covered — `progressing` (actively driving),
`awaiting-input` (blocked on a prompt), `thread-advanced` (a different
live turn), and the per-thread switch for "stop entirely".
`baseline.newestUserMessageId` stays: it is part of the persisted
record, it is re-captured on every (re)schedule, and it is what makes a
stranded arm diagnosable from the state file.
2. `decide.ts` — narrow `already-pending`. A rejection naming a CONCRETE
reset time later than the pending one now supersedes it instead of
being dropped, so a `seven_day` limit landing on an armed `five_hour`
no longer leaves the arm firing into a window that is still shut.
Restricted to `windowOpensInFuture` on purpose: a ladder-derived time
is `nowMs + delay`, so it is later on every telemetry re-emit, and
letting those supersede would push the arm out forever and flood the
timeline. An earlier reset never supersedes either — the existing arm
is already the conservative choice.
A supersede re-writes the record with a fresh `captureBaseline`, so it
is also the re-arm path, and posts a distinct
`t3x.auto-resume.rescheduled` note rather than a second "scheduled".
The issue's third item — detecting the org monthly spend limit — is a
genuinely separate feature (no `account.rate-limits.updated` path reaches
it at all) and is deliberately not in scope here, per the triage.
Tests: 4 new behavioural cases, each verified to fail against the old
code — guards (a newer user message does not cancel; it still cancels
when that message is actually being worked on), decide (supersede,
earlier-window no-op, ladder-churn guard), and two reactor integration
tests covering the reported shape end to end. Reactor suite run 12x for
flake. `docs/t3x/loop/DESIGN.md` §6 gets a dated note: guard #9 still
stands, but the hazard it was defending against is gone.
0 commit comments