You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit ecefeba
Browse filesBrowse the repository at this point in the historyBrowse files
feat(coil): move the release identity, offsetting the counter so clients keep updating (#71)
workflow .github/workflows/t3x-release.yml -> coil-release.yml
tags t3x-build-<sha> -> coil-build-<sha>
version 0.0.33-t3x.N -> 0.0.33-coil.N
manifest t3x-latest.json -> coil-latest.json
assets T3Code-<sha>-<arch> -> T3Coil-<sha>-<arch>
The workflow rename is the dangerous part, and not for any reason the issue predicted.
BUILD_COUNTER is github.run_number, and run_number is scoped to a workflow that GitHub identifies
by its FILE PATH. Renaming the file starts a new sequence at 1. That number is the manifest's
buildNumber, and decision.ts is a bare `manifest.buildNumber <= installed.buildNumber` — so the
first renamed release would have offered build 1 to clients sitting at 26, every one of them would
have skipped, and they would have gone on skipping forever with no symptom, because "skip" is the
ordinary outcome of that branch and looks exactly like being up to date.
Hence `github.run_number + 100`, which clears both the last run under the old filename (32) and the
last published build (26). The first coil build is 101. The offset is permanent; the comment on it
says so, at length, because it reads like something to tidy up.
Two consequences of that offset, one of which was a live bug for a while:
- build-update-manifest.mjs asserts VERSION ends with `-coil.<RUN_NUMBER>`, and the workflow was
passing raw github.run_number to it. With the offset applied to the version but not to
RUN_NUMBER, that assertion fails on every release. The resolve job now publishes the counter as
a `build_number` output and the manifest step reads that — one number, resolved once.
- parseBuildNumber accepts `-coil.N` AND keeps `-t3x.N`. Not sentiment: every published build up to
26 carries the old suffix, and returning undefined for those reads as "no ordering floor", the
one answer that lets an older build look installable. Ordering survives the rename because the
counter did, not because the suffixes compare — and they do not, `coil` sorts before `t3x`.
The changelog's previous-tag lookup now spans both prefixes, permanently. Without that the first
coil release finds no tag, takes the "first release ever" branch, and ships an empty changelog for
a build with twenty commits in it.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
# The install steps used to live inline in this file, which made the release body the only
596
625
# place they existed — and the download page pointed at "the release notes" without linking
597
626
# them, so a first-time reader could go from the landing page to an app macOS calls damaged
598
627
# having never seen one (issue #72). Both surfaces now render
599
-
# scripts/t3x/install-instructions.json.
628
+
# scripts/coil/install-instructions.json.
600
629
#
601
630
# A rendering failure must not cost a release: by the time this step runs, both matrix legs
602
631
# have finished and ~22 minutes of macOS and Windows compute is already spent. So a failure
@@ -610,9 +639,9 @@ jobs:
610
639
NOTES_PATH: ${{ runner.temp }}/release-notes.md
611
640
run: |
612
641
set -uo pipefail
613
-
if ! node scripts/t3x/render-release-notes.mjs \
642
+
if ! node scripts/coil/render-release-notes.mjs \
614
643
--sha "$FULL_SHA" --short-sha "$SHORT_SHA" > "$NOTES_PATH"; then
615
-
echo "::warning::Could not render the install notes; publishing a minimal body. This is a bug in scripts/t3x/render-release-notes.mjs — the release itself is fine."
644
+
echo "::warning::Could not render the install notes; publishing a minimal body. This is a bug in scripts/coil/render-release-notes.mjs — the release itself is fine."
616
645
printf 'Automated fork build of `%s`.\n\nInstall instructions: https://coil.curlycloud.dev/download\n' \
617
646
"$FULL_SHA" > "$NOTES_PATH"
618
647
fi
@@ -630,8 +659,8 @@ jobs:
630
659
name: ${{ needs.resolve.outputs.version }}
631
660
prerelease: true
632
661
files: |
633
-
staged/T3Code-*
634
-
staged/t3x-latest.json
662
+
staged/T3Coil-*
663
+
staged/coil-latest.json
635
664
fail_on_unmatched_files: true
636
665
body_path: ${{ steps.notes.outputs.path }}
637
666
@@ -665,7 +694,7 @@ jobs:
665
694
# comes along to heal it.
666
695
#
667
696
# If it still gives up, the build is recoverable without a new commit — this workflow takes a
668
-
# `sha` input, so `gh workflow run t3x-release.yml -f sha=<sha>` republishes it.
697
+
# `sha` input, so `gh workflow run coil-release.yml -f sha=<sha>` republishes it.
0 commit comments