You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a4b43a3
Browse filesBrowse the repository at this point in the historyBrowse files
authored and
coil-sync-bot
committed
fix(t3x): give the fork its own bundle id, so it stops sharing TCC rows with upstream (#70)
Stable signing was necessary but not sufficient. macOS stores one TCC
permission row per (service, bundle id), and both apps report the same id:
$ mdls -name kMDItemCFBundleIdentifier "/Applications/T3 Code (Alpha).app" \
"/Applications/T3 Code (Nightly).app"
com.t3tools.t3code
com.t3tools.t3code
So the fork's build and upstream's nightly shared one row per permission, and
whichever launched last owned it — the other was re-prompted no matter how well
either was signed. Anyone running both was getting dialogs from this on top of
the cdhash problem.
The fork now uses dev.curlycloud.coil, after coil (coil.curlycloud.dev).
DESKTOP_APP_ID becomes an env escape hatch rather than a changed literal:
`process.env.T3X_DESKTOP_APP_ID?.trim() || "com.t3tools.t3code"`. That keeps
upstream's default, upstream's three assertions on the value, and upstream's
behaviour on an unset environment — a changed literal would have cost a second
seam row on build-desktop-artifact.test.ts as well. One line, ten of comment,
recorded in SEAMS.md as the ledger's 38th row and its first deletion.
Two deliberate non-changes:
- productName stays "T3 Code (Alpha)". The updater refuses an install when the
.app name inside the dmg differs from the installed one, so renaming the app
would break the update path this is meant to make quiet (#71).
- User data does not move: ~/Library/Application Support/t3code comes from a
hardcoded userDataDirName, not from the bundle id.
Landing in the same release as the signing change costs ONE round of permission
prompts between them rather than two.
Guarded from the fork side, because a silent revert here is invisible until the
dialogs come back days later on someone's machine: mac-signature.test.ts asserts
the hook still exists and that the release workflow, the local autobuild and the
certificate setup all set it to the same value, and verify-mac-signature.ts
fails any artifact whose signing identifier is not that value.
The one remaining failing test is the pinned designated requirement, which does
not exist yet — it lands with the certificate's trust step.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|`apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift`| +33/-0 | 6 |**198**| Shift+Return newline vs. bare Return submit |
196
+
|`scripts/build-desktop-artifact.ts`| +11/-1 | 15 |**180**| Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/t3x/mac-signature.test.ts` (the hook exists, every build path sets it) and by `scripts/t3x/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
0 commit comments