You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8d87b8b
Browse filesBrowse the repository at this point in the historyBrowse files
docs(coil): resolve the independent review's findings across the Loops package
A five-axis review (standards / spec / claim re-verification / internal
consistency / prototype QA) turned up 102 findings, ~60 unique. The
load-bearing ones, all verified against the code before editing:
- The compose-don't-replace correction was applied unevenly: the check-in
prompt still said "I am the scheduler for this thread. Do not schedule
your own wake-ups", the report kept the CLAUDE_CODE_DISABLE_CRON switch
PLAN drops, and the report's deferred table still had session_crons in
Phase 3. All now carry the composed story.
- Deference now matches #42's Guard #15: T3 stands down while a recorded
wake is pending regardless of distance (the binary clamps at 3600s),
and fires wake_lost only past a new wakeGraceMs. TESTS 11c reworded.
- session_crons carries a cron EXPRESSION, not a timestamp
(SessionCronSummary in sdk.d.ts 0.3.170) — the nextFireAtMs parse is
the fork's and is now an explicit [A].
- pingdotgg#5127's voiding was overstated: the aborted branch resolves the
Deferred with {} but then DENIES the tool call while the session stops.
What survives is user-input.resolved with empty answers — voided reads
as answered downstream, which is still why the durable record exists.
- The §1.4 "second kill" is gone upstream (pingdotgg#5710, e70cdb4): the
no-turnState branch emits token usage plus a log, no lifecycle event.
- total_cost_usd is stamped onto turn.completed.totalCostUsd, not
"unread"; nothing aggregates it, and its semantics stay [A].
- Numbers re-stamped on the a4cc136 ledger: ClaudeAdapter churn 16 /
~4.6k lines, orchestration.ts 20, settingsSearch.ts 14, SettingsPanels
36/2088, contracts/settings 26, the _chat row churn 4 / risk 64 (the
fork's added delta stays 0), Sidebar +184/-81. #112 answered with
measured churn (RightPanelTabs 14, rightPanelStore 7).
- Seam accounting unified on PLAN §6 (3 rows, phases 1-4);
SETTINGS_SECTION_ICONS attributed to SettingsSidebarNav.tsx; the
"search-invisible" claim dropped (the id union is derived).
- Fork main SHAs are rewritten by every sync, so the docs now anchor on
the merge-base; the 08-18 force-rewrite to 94c6328 is recorded.
- Report section refs renumbered after the mobile insert (§13→§14 etc.),
the 137-sum test table now sums to 159, the orphaned decision-4 chips
and the four-vs-five scenario counts fixed.
- Prototypes: tokens re-lifted where they had drifted ([data-app-sidebar]
values, sky-300 not sky-400, computed base literals), p5 gains the
self-pacing and wake-lost states (15 total), the spinner became the
product's stepped pulse, switches got role/aria, p2 prices the sidebar
row chrome honestly (deferred — it would be a new Sidebar.tsx row),
p6/p3 align with #44's v1 contract (never pushes, PRs opt-in later).
- build-report.mjs: function replacer, escapeHtml on marker fields, a
GENERATED banner in the output, honest self-containedness claim, +x.
- LoopRecord gains the checkIns array the console's ledger reads;
workSource leaves phase 1 (lands with #44); stop-with-pending-crons
now calls stopSession, the honest cancel from #42 1c.
- The archived loop/ design's DESIGN.md banner no longer overclaims, and
its report.html carries a superseded pointer.
Co-Authored-By: Claude Fable 5 <[email protected]>
commits behind upstream at verification (2026-08-17)**. Every claim below was verified against that tree — see
3
+
**Status:**proposed — nothing built.
4
+
**Baseline:**upstream merge-base `a4cc1367b` (2026-08-17), with the fork **zero commits behind
5
+
upstream at verification (2026-08-17)**. The merge-base is the anchor rather than a fork `main` SHA,
6
+
because every sync rewrites `main`. Every claim below was verified against that tree — see
7
7
[UPSTREAM-DELTA.md](UPSTREAM-DELTA.md) §7.
8
8
9
9
| Companion doc | What it holds |
@@ -90,13 +90,13 @@ Each with the reasoning, so a reviewer can attack the reasoning rather than gues
90
90
| D1 |**Durable T3-native reactor, backstopping Claude's scheduler**| Claude's scheduler works ≤30min but is in-process, clamped to 1h, and Claude-only `[V]`| High — evidence in BACKEND §1.1 |
91
91
| D2 |**Trigger on `updatedAt` staleness + recorded `session_crons`, never `session.status`**| A background subagent's message auto-opens a synthetic turn that pins `status = running` and nothing closes it — gating on it deadlocks the exact threads this is for `[V]`| High |
92
92
| D3 |**A loop is a pinned thread** (Direction A) | Upstream shipped pinning 2026-08-04; `pinnedAt` overrides the settled/snoozed lifecycle; costs zero sidebar edits `[V]`| High |
93
-
| D4 |**The Loops workspace (Direction C) is phase 2, not phase 1**| User agreed. Lives in fork-owned routes, so cost is low, but it is only worth it once several loops exist | High — user-confirmed |
93
+
| D4 |**The Loops workspace (Direction C) is a later phase (Phase 6), not phase 1**| User agreed. Lives in fork-owned routes, so cost is low, but it is only worth it once several loops exist | High — user-confirmed |
94
94
| D5 |**Never Direction B** (a bespoke Loops section in the sidebar) | Would open a row in `Sidebar.tsx` (3911 lines, 7 commits in 3 days `[V]`) and `Sidebar.logic.ts`; also has no mobile equivalent | High |
95
95
| D6 |**Two question channels: blocking (native) + deferred (`raise_blocker`)**|`AskUserQuestion` blocks on a `Deferred``[V]`; a loop that waits loses the night, and one that nudges past a pending decision is worse | High |
96
96
| D7 |**Console reads three sources, two needing no model cooperation**| Degradation test: a model that never calls `raise_blocker` must still produce a useful console | High |
97
-
| D8 |**Budget is check-ins + wall-clock, not dollars**|`total_cost_usd`is unread anywhere in the repo and is documented as session-accumulated, so per-turn summing would inflate quadratically`[A - not measured]`| Medium — revisit if metered |
97
+
| D8 |**Budget is check-ins + wall-clock, not dollars**|The adapter stamps `total_cost_usd`onto `turn.completed.totalCostUsd` and nothing downstream aggregates it; its per-turn vs session-accumulated semantics are unmeasured `[A]`, so summing perturn could inflate quadratically | Medium — revisit if metered |
98
98
| D9 |**Mandatory budget, no unlimited option; route returns 400 rather than clamping**| A silent clamp hides a mistake in a feature that spends money unattended | Medium |
99
-
| D10 |**Own settings section** (`/settings/loops`) | Now priced at 2 small additive seam rows, with a 3-day-old upstream precedent `[V]`| High |
99
+
| D10 |**Own settings section** (`/settings/loops`) | Now priced at 2 small additive seam rows, with an upstream precedent that landed the same day (2026-08-17)`[V]`| High |
100
100
| D11 |**Fork-owned durable JSON, not a DB migration**| The migration registry is upstream-owned; `autoResume` set this precedent and it has held | High |
101
101
| D12 |**Zero `packages/contracts` edits**| Activity `kind` is an open string with an `Unknown` payload, so breadcrumbs are free; and upstream has pre-announced this file as its own automations landing zone | High |
102
102
@@ -111,7 +111,8 @@ Each with the reasoning, so a reviewer can attack the reasoning rather than gues
**Seam cost:****2 new rows**, ~+6 lines total, both additive.
296
313
**Sequencing:** no longer a constraint. This originally had to wait for the sync carrying upstream
@@ -386,7 +403,7 @@ The four to write first:
386
403
387
404
| Risk | Likelihood | Impact | Mitigation |
388
405
|---|---|---|---|
389
-
|`session_crons`is not delivered as the SDK types document | Medium `[A]`|Phase 1 invalid |**Phase 1 is designed to find this out cheaply.** Fallback is pure staleness with a longer threshold — worse, but zero upstream cost |
406
+
|`session_crons`arrives as a cron *expression*, not a fire time, so the `nextFireAtMs` parse is ours and can be wrong | Medium `[A]`|Deference misfires |**Phase 1 is designed to find this out cheaply** — it logs the parse beside the raw `schedule`. Fallback is pure staleness with a longer threshold — worse, but zero upstream cost |
390
407
| Upstream ships its own automations feature | Medium | Duplicated work | Zero contracts edits means the fork becomes a *caller*, not a migration. Re-check each sync |
391
408
| The `ClaudeAdapter` row conflicts on a sync | Low-Medium | Recurring cost | One additive line beside an existing spread; fails to a type error, not silent drift |
392
409
| A loop pushes past a human decision | Low | Trust | Three separate guards (approvals, pending input, plan-ready), each non-consuming |
@@ -402,8 +419,9 @@ The four to write first:
402
419
The four places an outside opinion is most valuable.
403
420
404
421
**Q1 — Is the deference rule right, or too clever?**
405
-
T3 stands down when the agent has a wake pending. The alternative is that T3 always paces on its own
406
-
clock and simply tolerates occasional double-firing. Deference is more correct and more complex, and
422
+
T3 stands down for as long as a recorded wake is still pending — any legal delay, not merely one
423
+
inside the threshold window — and covers it only once it is overdue by `graceMs`. The alternative is
424
+
that T3 always paces on its own clock and simply tolerates occasional double-firing. Deference is more correct and more complex, and
407
425
it makes the feature's behaviour depend on a hook whose delivery is `[A]`. *Is the complexity worth
408
426
it, or should v1 pace unconditionally with a long threshold?*
0 commit comments