You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5ee76a8
Browse filesBrowse the repository at this point in the historyBrowse files
fix(coil): restore the release, and make two of its checks capable of failing
Releases have been red since #53 landed. Build 106 was the last one published;
every run after it failed before publishing anything. Three defects, all in the
new bundle-size checks, and the third is the one worth reading twice.
1. The exclusions CLI wrote nothing on Windows.
All three scripts guarded their CLI entry point with
`import.meta.url === \`file://${process.argv[1]}\``. That is false on Windows,
where argv[1] is a native path: the template builds `file://D:\a\...` while
`import.meta.url` is `file:///D:/a/...`. It works on macOS and Linux only
because an absolute POSIX path already begins with `/`, which is why it
passed review and passed on one runner.
So `node desktop-file-exclusions.mjs` parsed, ran nothing, wrote nothing and
exited 0, and the release step correctly refused an empty exclusion list.
The same guard is in verify-desktop-bundle.mjs, which the release invokes as
a CLI — so on Windows that verification would have exited 0 without running
even once the rest of this was fixed. Fixed with `pathToFileURL`, which is
what Node provides for this conversion.
2. app.asar was never under release/.
Both checks searched `release/`. The build copies only FILES out of its
staging dir — `if (!stat || stat.type !== "File") continue` — and the macOS
`.app` and Windows `win-unpacked/` are directories, so the trees holding
app.asar are never copied there. The staging dir was also a SCOPED temp dir,
deleted when the build exits, so there was nothing to find anywhere.
T3CODE_DESKTOP_KEEP_STAGE keeps it, one new step resolves it through
`os.tmpdir()` rather than assuming /tmp or %TEMP%, and a cleanup step drops
it again before the upload.
3. The app-update.yml guard had never been able to fail.
Same wrong directory, opposite outcome. It searched release/ for a file that
only exists inside the .app, found nothing, printed "No app-update.yml
packaged", and passed — every run, unconditionally. It was never checking the
claim it is the only evidence for: that this fork's toast is the sole update
surface and upstream's electron-updater is off.
A check that fails loudly costs one red build. A check that cannot fail costs
nothing until the day it was supposed to catch something.
Tests cover the shape that broke rather than the line: invoked as a CLI, these
scripts must actually do something. They cannot run on Windows here — this fork
has no Windows CI runner — so that platform's correctness rests on pathToFileURL
being the right primitive, not on a green check. That asymmetry is the same one
that let this ship.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
0 commit comments