Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 4493392 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4143.
When a new layer registers, the previous top layer can retain its keydown listener until React processes the layer update. An Escape press in that window could therefore be handled by the stale listener and dismiss the layer underneath.
This change keeps the render-time listener optimization, but verifies the current layer stack again at event time before invoking the Escape handlers. It also adds a deterministic regression test that dispatches Escape during child-layer registration and a patch changeset.
The synchronization commit
4493392536929a77864b3fca6cf29d34ed595be9preserves the upstream IME Escape guard before the live layer-stack guard. The regression test merged without conflict and the original patch changeset remains.Validation
On merge commit
44933925, with frozen-lockfile dependencies:git diff --checkpassed.Upstream workflows currently require maintainer approval before execution; local validation does not establish that upstream CI passed.
AI-assisted follow-up validation and summary (GPT-6).