Repository navigation
Fix #16533 - Decode the TriCore 1.6 BOL loads and stores ##disasm - #27333
Merged
Merged
Conversation
…isasm The opcode table had the base + long offset (BOL) forms only for ld.a, ld.w, lea, st.b and st.w. Add ld.b, ld.bu, ld.h, ld.hu, st.a and st.h (opcodes 0x79, 0x39, 0xc9, 0xb9, 0xb5 and 0xf9), for the v2 cpu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16533. The TriCore table had the base + long offset (BOL) form only for
ld.a,ld.w,lea,st.bandst.w. So the TriCore 1.6 BOL loads and stores decoded asinvalid. For example,39ff0c35(ld.bu d15, [a15]0x50ccin Ghidra) gaveinvalidfollowed by a misread 16-bitld.bu.This adds the missing rows, each placed before its mnemonic's first 32-bit row as the ordering comment asks:
ld.bd@wld.bud@wld.hd@wld.hud@wst.a@wast.h@wdThe opcodes match Ghidra's
tricore.sinc.The rows are gated on
TRICORE_V2_UP, since these forms first appear in TC1.6; Capstone gates the same six onHasV160_UP. With the default cpu they are stillinvalid, and with-c v2they decode. There is no TriCore assembler, so assembly is unaffected.Testing
db/anal/tricoredecodes all eleven BOL forms with-c v2. It fails on master.db/cmd/cmd_list"List Parser Plugins Lp", which fails on master too.sys/lint.py --allis clean.