Repository navigation
Sort the r2pm -l and -s listings ##r2pm - #27315
Merged
Merged
Conversation
Both printed packages in readdir order, which depends on the filesystem, so the "r2pm installs missing dependencies and stops when one fails" test listed depok before depapp on ext4 and failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
r2pm -landr2pm -sprinted packages inreaddirorder, which depends on the filesystem. The new test "r2pm installs missing dependencies and stops when one fails" (123e467) expectsdepappbeforedepok, but on ext4-qlcan listdepokfirst. Solinux-testandubuntu-tcc-testfail on some runs of unrelated PRs, for example #27313. Both listings are now sorted by name, so the output and the test are stable.Testing
db/tools/r2pmfails on master on an ext4 WSL box in 3 of 3 runs. With this change it passes in 3 of 3: 34 OK, 0 XX.r2r db/tools: 0 failures.sys/lint.py --allis clean.