Repository navigation
Fix null dereferences in the dis and pyc disassemblers without a loaded file ##crash - #27139
Merged
Merged
Conversation
…ed file ##crash Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
two disassemblers crash when there is no file behind the bytes , as with
rasm2 -d:disonly setsowhen the dis bin plugin is loaded , butjmp,calland the conditional branches reado->pcsanyway . a smallresolve_pcreturnsUT64_MAXwhen there is no module , which is what a pc that is not in the table already gavepycreadb->curwith noRBin, that isR_UNWRAP4now . after that it passed the unsetasm.cputostrcmpinget_opcode_by_version, so with no cpu it takes the samev3.9.0table an unknown version already falls back to . without the pyc file there are no code objects , so the bytes come out asinvalid, as they do inside r2 on a raw bufferfound with an ASan build , disassembling random 1 to 16 byte strings with every plugin
rasm2 -Llists that can disassemble , 100 per plugin . these two were the only reports , with the change the same 8500 runs report nothing . the 4 lines indb/asm/dis_32anddb/asm/pyccrash before the change .