Repository navigation
Fix stores, srai and jalr in the RISC-V assembler ##arch - #27133
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the RISC-V assembler sent everything through the I-type encoder , so some instructions came out as something else :
sw a1, 8(sp)a3258100=sw s0, 11(sp)2324b100srai a0, a0, 313553500=srli a0, a0, 313553540jalr ra, 8(a0)Missing argument, thene7f0ffffe7008500sb,shandsdare added next toswsraihas its0x20funct7 ,slliandsrliare added , the shift amount is checked to be 0..63jalrandjrtakers,rd, rs,imm(rs)andrd, imm(rs)lb,lh,ld,lbu,lhuandlwuare added , they work likelwfound by decoding random words with llvm-mc , assembling the text with
rasm2 -a riscvand decoding the result again . out of 3482 distinct instructions , 880 came back the same before and 1934 now , the wrong ones went from 315 to 5 (c.nopwith a hint immediate ) and none that were right changed . the 16 new lines indb/asm/riscv_64check against llvm's bytes , 15 of them fail before the change .db/asmhas no failures .