Repository navigation
Fix #27096 - Do not sort a wasm section vector that failed to parse or is empty ##bin - #27118
Merged
Merged
Conversation
…o parse or is empty ##bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
parse_vecreturns NULL when a section has no entries , andparse_sub_section_vecthen sorted that NULL vector , so the reproducer from #27096 , an export section with count 0 , aborted with assertions on and printed a warning without them . the sort is skipped when there is nothing to sort .the new r2r test writes the same 11 bytes into
malloc://and loads them withoba, so no binary fixture is needed . it fails before the change , the assertion aborts , and passes after .db/formats/web_assembly10 OK ,db/anal/wasm22 OK ,db/cmd/cmd_iw21 OK .rabin2 -Iandrabin2 -eon the reproducer exit 0 withR2_DEBUG_ASSERT=1.