Bring back tcc support ##build by trufae · Pull Request #17295 · radareorg/radare2

trufae · 2020-07-16T16:55:52Z

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've added tests that prove my fix is effective or that my feature works (if possible)
I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description

Building r2 with TCC is somewhat desirable. This PR aims to fix #4328

Test plan

Maybe add a github action with the following lines:

r2pm -ci tcc
export CC="tcc"
r2pm -r ./configure --with-compiler=tcc
r2pm -r make

Closing issues

Closes #4328

XVilka · 2020-07-17T04:13:38Z

It fails because of the TCC error it seems:

tcc: x86_64-gen.c:452: load: Assertion `((ft & VT_BTYPE) == VT_INT) || ((ft & VT_BTYPE) == VT_LLONG) || ((ft & VT_BTYPE) == VT_PTR) || ((ft & VT_BTYPE) == VT_FUNC)' failed.
make[3]: *** [/home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_mach0.o] Aborted (core dumped)
/home/runner/work/radare2/radare2/libr/../global.mk:38: recipe for target '/home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_mach0.o' failed
make[3]: Leaving directory '/home/runner/work/radare2/radare2/libr/bin'
make[2]: *** [bin] Error 2
Makefile:159: recipe for target 'bin' failed
make[1]: *** [all] Error 2
make[2]: Leaving directory '/home/runner/work/radare2/radare2/libr'
Makefile:22: recipe for target 'all' failed
make[1]: Leaving directory '/home/runner/work/radare2/radare2/libr'
Makefile:56: recipe for target 'all' failed
make: *** [all] Error 2

ret2libc · 2020-07-17T11:01:29Z

Removing from 4.5.0 because this has been an issue for over 3 years, I don't think it's that important at this point.

XVilka · 2020-07-24T06:11:04Z

Probably we should send a bug description (or a patch) to tinycc-devel mailing list. Apparently there is a lot of activity happenning there.

XVilka · 2020-08-10T07:56:11Z

TinyCC developers fixed the problem, also attached the patch to radare2, but it's still not sufficient to build it: https://lists.nongnu.org/archive/html/tinycc-devel/2020-08/txt5WwrLjrHAf.txt

trufae · 2020-08-12T19:52:00Z

I'm not sure about the extra dependencies, if those are really needed why they didnt failed in any other compiler? would be good to compare make depgraph to see if there's any issue there

trufae · 2020-08-12T19:52:58Z

Good patches @XVilka ! is there any other patch for tcc needed to continue in here? can you post the fixes/commits/issues from their repo? thanks!

XVilka · 2020-08-14T05:38:37Z

These are commits in TinyCC itself that were done for various bugs preventing to compile radare2:

XVilka · 2020-08-14T05:39:57Z

Seems the only remaining problem is this library dependency, can you @trufae please check? Just be sure to update tcc first.

XVilka · 2020-09-10T04:23:30Z

Still a dependency problem:

2020-09-10T04:12:47.3536463Z "tcc -D__LITTLE_ENDIAN__=1 -shared -Dxx -o libr_bin.so -sonamelibr_bin.so bin.o dbginfo.o bin_ldr.o bin_write.o demangle.o dwarf.o filter.o bfile.o bobj.o blang.o mangling/cxx/cp-demangle.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_any.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_art.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_avr.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_bf.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_bflt.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/bflt/bflt.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_bios.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_bootimg.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_cgc.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_coff.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/coff/coff.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_dex.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_dbginfo_dex.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/dex/dex.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_dmp64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/dmp/dmp64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_dol.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_dyldcache.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_elf.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_dbginfo_elf.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_write_elf.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/elf/elf.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/elf/elf_write.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_elf64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_dbginfo_elf64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_write_elf64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/elf/elf64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/elf/elf64_write.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_fs.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_java.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_le.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/le/le.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_mach0.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mach0/mach0.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/objc/mach0_classes.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/objc/mach064_classes.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_write_mach0.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_mach064.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_write_mach064.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mach0/mach064.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_mbn.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_mdmp.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mdmp/mdmp.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mdmp/mdmp_pe.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mdmp/mdmp_pe64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_menuet.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_mz.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mz/mz.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_ne.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/ne/ne.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_nes.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_nin3ds.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_ninds.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_ningb.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_ningba.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_nro.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_nso.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/nxo/nxo.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_omf.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/omf/omf.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_p9.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/p9/p9bin.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_pe.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_write_pe.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/pe/pe.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/pe/pe_write.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_pe64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_write_pe64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/pe/pe64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/pe/pe64_write.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_pebble.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_prg.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_psxexe.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_pyc.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/pyc/marshal.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/pyc/pyc_magic.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/pyc/pyc.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_qnx.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_sfc.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_smd.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_sms.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_spc700.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_symbols.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mach0/coresymbolication.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_te.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/te/te.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_vsf.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_wasm.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/wasm/wasm.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_xbe.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_xnu_kernelcache.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/xnu/r_cf_dict.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_z64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_zimg.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/zimg/zimg.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_xtr_dyldcache.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mach0/dyldcache.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_xtr_fatmach0.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/mach0/fatmach0.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_xtr_pemixed.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/../format/pe/pemixed.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_xtr_sep64.o /home/runner/work/radare2/radare2/libr/..//libr/bin/p/bin_ldr_linux.o mangling/demangler.o mangling/microsoft_demangle.o mangling/objc.o mangling/cxx.o mangling/msvc.o mangling/swift.o mangling/swift-sd.o mangling/java.o mangling/rust.o pdb/pdb_downloader.o pdb/omap.o pdb/stream_pe.o pdb/gdata.o pdb/fpo.o pdb/dbi.o pdb/tpi.o pdb/stream_file.o pdb/pdb.o  -L/home/runner/work/radare2/radare2/libr/util -L/home/runner/work/radare2/radare2/libr/io -L/home/runner/work/radare2/radare2/libr/socket -L/home/runner/work/radare2/radare2/libr/magic -L/home/runner/work/radare2/radare2/libr/hash -L/home/runner/work/radare2/radare2/libr/syscall -L/home/runner/work/radare2/radare2/libr/cons -lr_util -lr_io -lr_socket -lr_magic -lr_hash -lr_syscall -lr_cons   -fPIC /home/runner/work/radare2/radare2/libr/../shlr/zip/librz.a /home/runner/work/radare2/radare2/libr/../shlr/zip/librz.a /home/runner/work/radare2/radare2/libr/..//shlr/yxml/libyxml.a /home/runner/work/radare2/radare2/libr/..//shlr/java/libr_java.a /home/runner/work/radare2/radare2/libr/..//shlr/ar/libr_ar.a -fvisibility=hidden    -fvisibility=hidden"
2020-09-10T04:12:47.3741114Z tcc: error: referenced dll 'libr_crypto.so' not found
2020-09-10T04:12:47.3741427Z tcc: error: library 'r_io' not found
2020-09-10T04:12:47.3752606Z make[3]: *** [libr_bin.so] Error 1
2020-09-10T04:12:47.3753308Z /home/runner/work/radare2/radare2/libr/..//libr/rules.mk:82: recipe for target 'libr_bin.so' failed
2020-09-10T04:12:47.3754020Z make[3]: Leaving directory '/home/runner/work/radare2/radare2/libr/bin'
2020-09-10T04:12:47.3757734Z make[2]: *** [bin] Error 2
2020-09-10T04:12:47.3758170Z Makefile:166: recipe for target 'bin' failed
2020-09-10T04:12:47.3759216Z make[1]: *** [all] Error 2
2020-09-10T04:12:47.3759714Z make[2]: Leaving directory '/home/runner/work/radare2/radare2/libr'

codecov-commenter · 2020-09-10T06:24:11Z

Codecov Report

Merging #17295 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #17295   +/-   ##
=======================================
  Coverage   40.16%   40.16%           
=======================================
  Files        1132     1132           
  Lines      356623   356623           
=======================================
+ Hits       143238   143248   +10     
+ Misses     213385   213375   -10

Impacted Files	Coverage Δ
shlr/tree-sitter/lib/src/atomic.h	`66.66% <ø> (ø)`
shlr/tree-sitter/lib/src/bits.h	`0.00% <ø> (ø)`
libr/core/task.c	`61.22% <0.00%> (+2.67%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcce83...cb901a9. Read the comment docs.

trufae · 2020-09-14T17:36:20Z

@XVilka any update from tcc devs?

XVilka · 2020-09-21T04:34:30Z

@trufae update for what? They fixed all bugs in git that were found during the radare2 compilation. It's now only the dependency problem that prevents radare2 being built.

trufae · 2020-09-21T16:25:43Z

Amazing! great to see tcc back to r2land. ive checked the error and it seems like its not buildling r_io for some reason i ignore . therefor later it fails. can i have a shell in this env? otherwise i can try to repro in local. Can you repro?

XVilka · 2020-09-22T04:41:26Z

It builds r_io just fine, I think:

tcc -D__LITTLE_ENDIAN__=1 -c    -fPIC -g -Wall -D__UNIX__=1 -Wall -DR2_PLUGIN_INCORE -I/home/runner/work/radare2/radare2/libr/../shlr/zip/include -I/home/runner/work/radare2/radare2/libr/..//shlr/ptrace-wrap/include -I/home/runner/work/radare2/radare2/libr/../shlr/ar -I/home/runner/work/radare2/radare2/libr/../shlr/bochs/include/ -I/home/runner/work/radare2/radare2/libr/../shlr/gdb/include/ -I/home/runner/work/radare2/radare2/libr/../shlr/qnx/include/ -I/home/runner/work/radare2/radare2/libr/../shlr/winkd -I../../shlr/zip/include  -I/home/runner/work/radare2/radare2/libr -I/home/runner/work/radare2/radare2/libr/include -I/home/runner/work/radare2/radare2/libr/../shlr/sdb/src -fvisibility=hidden -o io_fd.o io_fd.c
"tcc -D__LITTLE_ENDIAN__=1 -shared -Dxx -o libr_io.so -sonamelibr_io.so p/io_ar.o p/io_bfdbg.o p/io_bochs.o p/io_debug.o p/io_default.o p/io_fd.o p/io_gdb.o p/io_gprobe.o p/io_gzip.o p/io_http.o p/io_ihex.o p/io_mach.o p/io_malloc.o p/io_mmap.o p/io_null.o p/io_procpid.o p/io_ptrace.o p/io_qnx.o p/io_r2k.o p/io_r2k_linux.o p/io_r2pipe.o p/io_r2web.o p/io_rap.o p/io_rbuf.o p/io_self.o p/io_shm.o p/io_sparse.o p/io_tcp.o p/io_w32.o p/io_w32dbg.o p/io_winedbg.o p/io_winkd.o p/io_zip.o io.o io_plugin.o io_map.o io_desc.o io_cache.o p_cache.o undo.o ioutils.o io_fd.o /home/runner/work/radare2/radare2/libr/..//shlr/ptrace-wrap/src/ptrace_wrap.o  -L/home/runner/work/radare2/radare2/libr/util -L/home/runner/work/radare2/radare2/libr/socket -L/home/runner/work/radare2/radare2/libr/hash -L/home/runner/work/radare2/radare2/libr/cons -L/home/runner/work/radare2/radare2/libr/crypto -lr_util -lr_socket -lr_hash -lr_cons -lr_crypto   -fPIC /home/runner/work/radare2/radare2/libr/..//shlr/ar/libr_ar.a /home/runner/work/radare2/radare2/libr/../shlr/zip/librz.a /home/runner/work/radare2/radare2/libr/..//shlr/gdb/lib/libgdbr.a /home/runner/work/radare2/radare2/libr/..//shlr/qnx/lib/libqnxr.a /home/runner/work/radare2/radare2/libr/..//shlr/ptrace-wrap/libptrace_wrap.a -fvisibility=hidden    -lutil -lr_cons -lutil /home/runner/work/radare2/radare2/libr/../shlr/ar/libr_ar.a /home/runner/work/radare2/radare2/libr/../shlr/bochs/lib/libbochs.a -lutil /home/runner/work/radare2/radare2/libr/../shlr/gdb/lib/libgdbr.a -lutil /home/runner/work/radare2/radare2/libr/../shlr/qnx/lib/libqnxr.a -lutil -lutil /home/runner/work/radare2/radare2/libr/../shlr/winkd/libr_winkd.a -fvisibility=hidden"
make[4]: Entering directory '/home/runner/work/radare2/radare2/libr/io/p'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/home/runner/work/radare2/radare2/libr/io/p'
make[3]: Leaving directory '/home/runner/work/radare2/radare2/libr/io'
DIR flag

XVilka · 2020-09-22T04:57:45Z

@ret2libc please take a look at tree-sitter library changes.

trufae · 2020-09-24T15:34:52Z

@XVilka imho its fine to merge in the current state. the remaining bug is not in our side i think

XVilka · 2020-09-27T05:36:05Z

I cherry-picked to master all changes in radare2 codebase itself. Therefore, three subsystems that are in fact external projects:

lz4 Fix compilation with TinyCC lz4/lz4#922 [MERGED]
tree-sitter Fix compilation with TinyCC tree-sitter/tree-sitter#743 [MERGED]
jemalloc Fix compilation with TinyCC compiler jemalloc/jemalloc#1943 [REJECTED]

We should try to mainline these changes.

XVilka · 2020-10-30T08:52:20Z

All possible changes were mainstreamed, all bugs in TinyCC were fixed. The only remaining issue is in radare2 - something about module dependency or so. @trufae

XVilka · 2020-12-04T07:56:37Z

The produced code is significantly slower but works.
There are still some test failures:


[XX] db/cmd/cmd_help "? -1"
R2_NOPLUGINS=1 radare2 -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -Qc '? -1' --
-- stdout
@@ -6,7 +6,7 @@
 segment fffff000:0fff
 string  "\xff\xff\xff\xff\xff\xff\xff\xff"
 fvalue: -1.0
-float:  nanf
-double: nan
+float:  -nanf
+double: -nan
 binary  0b1111111111111111111111111111111111111111111111111111111111111111
 trits   0t11112220022122120101211020120210210211220

 [XX] db/formats/mach0/mach0 mach0 headers2
R2_NOPLUGINS=1 radare2 -escr.utf8=0 -escr.color=0 -escr.interactive=0 -N -aarm -b32 -Qc iH bins/mach0/ired
-- stdout
@@ -55,8 +55,6 @@
 pf.mach0_entry_point_command @ 0x00004408
 0x00004408  cmd      11 0x80000028 LC_MAIN
 0x0000440c  cmdsize     24
-0x00004410  entry0      0x4da9
-0x00004414  stacksize   0x0
 pf.mach0_encryption_info_command @ 0x00004420
 0x00004420  cmd      12 0x21 LC_ENCRYPTION_INFO
 0x00004424  cmdsize     20

XVilka · 2020-12-09T05:13:18Z

@trufae @condret you can merge this even now - just keep in mind that the change in jemalloc should be repeated again in case you decide to update jemalloc to a new version.

Another thing - some tests are broken, but I think it's still better than broken compilation.

Also don't forget to remove these lines:

  # FIXME: To remove before merge!!!
  pull_request:
    branches:
    - master

trufae · 2020-12-11T08:42:27Z

Appreciate

This comment has been minimized.

Sign in to view

github-actions Bot added the infrastructure Issues related to the radare2/cutter infrastructure label Jul 17, 2020

ret2libc removed this from the 4.5.0 - Organized Chaos milestone Jul 17, 2020

This comment has been minimized.

Sign in to view

trufae requested a review from ret2libc as a code owner August 10, 2020 07:49

trufae requested a review from yossizap as a code owner August 10, 2020 08:02

github-actions Bot added the RBin label Aug 10, 2020

trufae requested a review from XVilka as a code owner August 12, 2020 07:14

github-actions Bot added the RCrypto label Aug 12, 2020

ret2libc added the waiting-for-author label Aug 26, 2020

ret2libc assigned ret2libc and unassigned ret2libc Aug 26, 2020

ret2libc marked this pull request as draft August 26, 2020 07:37

This comment has been minimized.

Sign in to view

trufae marked this pull request as ready for review September 24, 2020 15:34

trufae force-pushed the fix-tcc-build branch from 1578e53 to 0b7ca28 Compare September 24, 2020 17:03

trufae force-pushed the fix-tcc-build branch from 966d987 to c0e0420 Compare October 9, 2020 17:43

This comment has been minimized.

Sign in to view

radare and others added 2 commits December 4, 2020 16:31

Fix TinyCC build ##build

fb74b6d

Jemalloc - fix TinyCC build ##build

e575ca1

XVilka approved these changes Dec 9, 2020

View reviewed changes

trufae merged commit 6693e33 into radareorg:master Dec 11, 2020

Uh oh!

Conversation

trufae commented Jul 16, 2020 • edited by XVilka Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

XVilka commented Jul 17, 2020

Uh oh!

ret2libc commented Jul 17, 2020

Uh oh!

XVilka commented Jul 24, 2020

Uh oh!

This comment has been minimized.

XVilka commented Aug 10, 2020

Uh oh!

trufae commented Aug 12, 2020

Uh oh!

trufae commented Aug 12, 2020

Uh oh!

XVilka commented Aug 14, 2020

Uh oh!

XVilka commented Aug 14, 2020

Uh oh!

XVilka commented Sep 10, 2020

Uh oh!

codecov-commenter commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trufae commented Sep 14, 2020

Uh oh!

XVilka commented Sep 21, 2020

Uh oh!

trufae commented Sep 21, 2020

Uh oh!

XVilka commented Sep 22, 2020

Uh oh!

XVilka commented Sep 22, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

trufae commented Sep 24, 2020

Uh oh!

XVilka commented Sep 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XVilka commented Oct 30, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

XVilka commented Dec 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XVilka commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trufae commented Dec 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

trufae commented Jul 16, 2020 •

edited by XVilka

Loading

codecov-commenter commented Sep 10, 2020 •

edited

Loading

XVilka commented Sep 27, 2020 •

edited

Loading

XVilka commented Dec 4, 2020 •

edited

Loading

XVilka commented Dec 9, 2020 •

edited

Loading