Ignore param parsing errors in MethodOverride#835
Merged
matthewd merged 1 commit intorack:masterfrom Jun 12, 2015
greysteil:handle-param-parsing-errors-in-method-override
Merged
Ignore param parsing errors in MethodOverride#835matthewd merged 1 commit intorack:masterfrom greysteil:handle-param-parsing-errors-in-method-override
matthewd merged 1 commit intorack:masterfrom
greysteil:handle-param-parsing-errors-in-method-override
Conversation
Contributor
Author
|
@spastorino - looks like you reviewed the last change to |
Contributor
Author
|
@spastorino - would be great to get your opinion on whether this should be handled here or if the error should be caught in the framework. |
Contributor
|
Sorry, I'm right now with zero time to check this. |
Contributor
Author
|
Thanks @spastorino. Would be great to get your opinion when you have a moment |
Contributor
Author
|
Hate to nag but I'd love an opinion on this vs. rails/rails#19632 |
matthewd
added a commit
that referenced
this pull request
Jun 12, 2015
…-method-override Ignore param parsing errors in MethodOverride
matthewd
added a commit
that referenced
this pull request
Jun 12, 2015
…-method-override Ignore param parsing errors in MethodOverride
Contributor
Author
|
💖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If unparseable parameters are passed through
Rack::MethodOverrideit will bomb whilst looking for the_methodparameter. BecauseRack::MethodOverrideis usually included low down in the stack this exception often goes uncaught, causing a 500.This PR silently ignores parameter parsing errors that occur in
Rack::MethodOverride. If the params are used later the same exception will be raised, but this will typically be much higher up the stack, and after any exception handling middleware.See rails/rails#19632 for a discussion of this in Rails.