Ensure streaming response body is closed by Rack::MockResponse.#2423
Merged
Ensure streaming response body is closed by Rack::MockResponse.#2423
Rack::MockResponse.#2423Conversation
jeremyevans
reviewed
Feb 4, 2026
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Support for streamable bodies was only added in master, it's not in 3.2. I would classify it as a feature, not a bug fix, because MockResponse#body was not designed to support streamable bodies. So I wouldn't backport this to 3.2 or 3.1.
Member
Author
While I understand this point, |
ioquatix
force-pushed
the
mock_response-streaming-response-body-close
branch
from
d83a525 to
d24a834
Compare
jeremyevans
approved these changes
Feb 5, 2026
ioquatix
added a commit
that referenced
this pull request
Feb 12, 2026
ioquatix
pushed a commit
that referenced
this pull request
Feb 12, 2026
- Ensure streaming response body is closed by `Rack::MockResponse`. (#2423)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2422.
As this is a bug fix, can we back port it to 3.2 at least? 3.1 might be nice too. We'd need to include the changes introduced by #2420.