Fix MockResponse#body when the body is a Proc#2420
Merged
Conversation
Previously, we would see errors like
NoMethodError: undefined method 'each' for an instance of Proc
in Rails integration tests when using streaming response bodies.
jeremyevans
approved these changes
Jan 23, 2026
Member
|
I think this is a good step in the right direction, but we might want to also consider how a user might test actual bi-directional communication. |
ioquatix
approved these changes
Jan 24, 2026
ioquatix
added a commit
that referenced
this pull request
Feb 12, 2026
ioquatix
pushed a commit
that referenced
this pull request
Feb 12, 2026
- Ensure streaming response body is closed by `Rack::MockResponse`. (#2423)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would see errors like
in Rails integration tests when using streaming response bodies.