Make Rack::Lint disallow PATH_INFO="" SCRIPT_NAME=""#2316
Merged
Conversation
Contributor
Author
|
Looks like we'd need Sinatra to update their tests first: https://github.com/jeremyevans/rack/actions/runs/14003034172/job/39212820448#step:5:4764 |
Member
|
Let me re-iterate how glad I am that we test our major downstream dependencies. |
ioquatix
force-pushed
the
path-info-script-name-non-empty
branch
from
f1d68a9 to
345374c
Compare
Member
|
This should be fixed by sinatra/sinatra#2114 |
ioquatix
reviewed
Jul 28, 2025
ioquatix
approved these changes
Jul 28, 2025
Member
ioquatix
left a comment
ioquatix
left a comment
There was a problem hiding this comment.
LGTM. Sinatra now has the fix so it's up to them to implement it (or not).
This was previously allowed, even though the text implies it shouldn't be valid. As such, I consider this a bug fix and not a SPEC change.
ioquatix
force-pushed
the
path-info-script-name-non-empty
branch
from
345374c to
4d285ea
Compare
This was referenced Jul 30, 2025
ioquatix
added a commit
to sinatra/sinatra
that referenced
this pull request
Jul 30, 2025
This is a temporary fix for #2113 until rack/rack#2316 is merged.
Member
|
I've merged a temporary fix to skip the faulty tests in Sinatra, so this should now be green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously allowed, even though the text implies it shouldn't be valid. As such, I consider this a bug fix and not a SPEC change.
Fixes #2307.