Skip to content

Fix Rack::Lint error message for HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH#2007

Merged
ioquatix merged 1 commit intorack:mainfrom
Shopify:fix-lint-message
Jan 11, 2023
Merged

Fix Rack::Lint error message for HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH#2007
ioquatix merged 1 commit intorack:mainfrom
Shopify:fix-lint-message

Conversation

@casperisfine
Copy link
Contributor

Currently it's printing:

Rack::Lint::LintError: env contains HTTP_CONTENT_TYPE, must use

Which had me puzzled for quite a while.

…ENGTH

Currently it's printing:

```
Rack::Lint::LintError: env contains HTTP_CONTENT_TYPE, must use
```

Which had me puzzled for quite a while.
@ioquatix ioquatix merged commit 865454f into rack:main Jan 11, 2023
@ioquatix
Copy link
Member

Sorry about that, thanks for the fix!

ioquatix pushed a commit that referenced this pull request Jan 16, 2023
…ENGTH (#2007)

Currently it's printing:

```
Rack::Lint::LintError: env contains HTTP_CONTENT_TYPE, must use
```

Which had me puzzled for quite a while.

Co-authored-by: Jean Boussier <[email protected]>
tenderlove added a commit that referenced this pull request Jan 17, 2023
* 3-0-sec: (24 commits)
  bump version
  Update changelog
  Fix ReDoS vulnerability in multipart parser
  Fix ReDoS in Rack::Utils.get_byte_ranges
  Forbid control characters in attributes
  Bump patch version.
  `Rack::Request#POST` should consistently raise errors. (#2010)
  Fix Rack::Lint error message for HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH (#2007)
  Rack::MethodOverride handle QueryParser::ParamsTooDeepError (#2006)
  Bump patch version.
  Fix Regexp deprecated third argument with Regexp::NOENCODING (#1998)
  Update tests to work on latest Rubies. (#1999)
  Bump patch version.
  Allow passing through streaming bodies. (#1993)
  Remove unnecessary executable bit from test files (#1992)
  Fix Utils.build_nested_query to URL-encode all query string fields (#1989)
  Trim trailing white space throughout the project (#1990)
  Fix some typos (#1991)
  Remove leading dot to fix compatibility with latest cgi gem. (#1988)
  Fix outdated Rack::Builder rdocs and remove Lobster references (#1986)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants