Expect additional optional version segment in version test.#1913
Merged
ioquatix merged 1 commit intorack:2-2-stablefrom Jun 25, 2022
Merged
Expect additional optional version segment in version test.#1913ioquatix merged 1 commit intorack:2-2-stablefrom
ioquatix merged 1 commit intorack:2-2-stablefrom
Conversation
Member
|
@tenderlove just wondering if this was intentional in the sense that from what I can see, there has never been a security release in the past with a 4th version component. @simi I'm assuming this breaks all stable branches with this test in place? |
Contributor
Author
Yes, it expects 3 segments in version. With this PR there could be optional fourth as well. |
Member
|
@simi what I mean, is all stable 2.0, 2.1, 2.2 etc branches didn't expect a 4-component version? |
Member
|
I confirmed with @tenderlove that this is normative, so we will need to fix CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last release (2.2.3.1) has added fourth segment of version string which wasn't expected by one test related to
rackup -v. I have updated test to expect fourth (optional) segment.CI fail was introduced by f705eac.