Ensure Rack::QueryParser::ParamsTooDeepError is inherited from RangeError.#1864
Merged
ioquatix merged 1 commit intorack:2-2-stablefrom Apr 11, 2022
Merged
Conversation
Contributor
simi
commented
Apr 9, 2022
simi
commented
- this is to cover backward compatibility
ioquatix
reviewed
Apr 9, 2022
…rror. - this is to cover backward compatibility
simi
force-pushed
the
2-2-stable-ensure-range
branch
from
9cb077e to
0f5603c
Compare
ioquatix
approved these changes
Apr 10, 2022
Member
ioquatix
left a comment
ioquatix
left a comment
There was a problem hiding this comment.
Approved, but let's get feedback from @jeremyevans he might have a better suggestion we can learn from :)
jeremyevans
approved these changes
Apr 11, 2022
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
This seems unnecessary to me. We would never change the superclass of an exception class since it would break backwards compatibility. However, I don't object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.