Add Ruby 2.3 compatibility for tests, add Ruby 2.3 to CI.#1863
Merged
ioquatix merged 1 commit intorack:2-2-stablefrom Apr 10, 2022
Merged
Add Ruby 2.3 compatibility for tests, add Ruby 2.3 to CI.#1863ioquatix merged 1 commit intorack:2-2-stablefrom
ioquatix merged 1 commit intorack:2-2-stablefrom
Conversation
Contributor
simi
commented
Apr 9, 2022
simi
commented
- partially backporting 2833813
ioquatix
requested review from
ioquatix and
jeremyevans
and removed request for
jeremyevans
ioquatix
approved these changes
Apr 9, 2022
Member
ioquatix
left a comment
ioquatix
left a comment
There was a problem hiding this comment.
LGTM. @jeremyevans since I believe you wrote this patch, can you confirm it's being used correctly?
jeremyevans
approved these changes
Apr 10, 2022
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
This looks fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.