Make specs compatible with later Ruby and setup CI.#1839
Make specs compatible with later Ruby and setup CI.#1839rafaelfranca merged 2 commits intorack:2-2-stablefrom
Conversation
|
Thanks for this. In the future can you please give current maintainers time to review, which would include myself, @jeremyevans and @tenderlove :) |
|
🤔 I think I have missed Ruby 2.3 on CI, which is still supported for 2.2 series. I'll update the CI to add 2.3 as well (I'll need to somehow bandaid the psych dependency since Psych 4.x is not compatible with 2.3). |
|
@ioquatix since when I was demoted to not be a current maintainer? And based on what? Who defined that rule? |
|
Being more constructive, if you see anything wrong with the code, please let me know, I'll fix. Now setting those nonsense rules in a project that I'm maintainer more time than you, doesn't solve any problem. If you don't have any problem with the code that was merged, let's keep focusing in the real problems, not in trying to gatekeep fixes to real problems. |
|
@rafaelfranca I apologise for what I said, it was not intended to cause stress. I'm happy that you and @simi made this contribution, and I don't personally have any problem with the code that was merged, but given how critical some of this stuff is, it's good to have several sets of eyes on it. I actually really value @jeremyevans and @tenderlove's input input because they often bring important perspectives to changes like this (including compatibility, security, etc) and I try to involve them in every PR I create and try to get consensus of both of them where possible. This PR was proposed and merged within 10 minutes. I felt like this didn't give a chance to anyone else to review the code. There were a couple of other rapid fire PRs yesterday too. Let's figure out a process for ensuring PRs have the appropriate number of approvals before getting merged: #1842 I welcome your feedback on what this should look like. |
|
@simi I checked the issue with YAML. Yes, it's a problem and we addressed this in main already. You'll want to copy this fix in a followup PR. |
|
Thanks @ioquatix I'll backport this. |
3 participants
2-2-stableto make it easier to cut new releasesmainbranch one, but includes only ubuntu Ruby (since other rubies do fail for CGI dependency fail or (JRuby) fails the same way as atmain)mainJRuby CI, but I can't reproduce the problem locally./cc @rafaelfranca