Don't ary.inspect in the lint assertions (backport)#1765
Merged
ioquatix merged 3 commits intorack:2-2-stablefrom Oct 9, 2021
Merged
Don't ary.inspect in the lint assertions (backport)#1765ioquatix merged 3 commits intorack:2-2-stablefrom
ioquatix merged 3 commits intorack:2-2-stablefrom
Conversation
jeremyevans
requested changes
Jul 19, 2021
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
In terms of code, this is fine. However, it changes both files to be executable (100644 → 100755), which is definitely wrong.
Just to set expectations, I don't think we're planning on releasing 2.2.4 unless there is a security issue. However, I see no problem backporting this so that if we do release 2.2.4, it is included.
Contributor
Author
|
Thanks for pointing that out - I was on a Windows machine at the time and forgot to set core.fileMode false :). The modes are now what they were originally. |
jeremyevans
approved these changes
Oct 9, 2021
Contributor
Author
|
In case someone is curious, this made it to Rack 2.2.5 and newer (but the history doesn't seem to reflect that and I didn't add it to the changelog) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport to 2.2 of #1626 (fixing #1625)