Conversation
casperisfine
force-pushed
the
early-hints-spec
branch
from
a8de1fe to
8984266
Compare
casperisfine
force-pushed
the
early-hints-spec
branch
from
8984266 to
a14f36b
Compare
|
I'm okay with this, but I think we should defer to the response headers rather than re-specifying it to avoid duplicating the specifications. |
|
With the changes to SPEC since this was originally submitted, I think this will require significant changes before merging. @casperisfine Unless you want to work on this, I can see if I can update it tomorrow. |
|
I don't absolutely want to work on it, feel free to take over if you wish, but otherwise I can probably do that in a day or two. |
This is already de facto spec as both Unicorn and Puma implement it. The changes to SPEC are compatible with both implementations. Fixes rack#1692 Fixes rack#1695 Co-authored-by: Jeremy Evans <[email protected]>
casperisfine
force-pushed
the
early-hints-spec
branch
from
a14f36b to
66ac5ea
Compare
casperisfine
force-pushed
the
early-hints-spec
branch
from
66ac5ea to
f49b0ea
Compare
|
Sorry for the delay, I rebased and replaced the content of It's been a while, so I hope the result is decent. Again feel free to directly take over if you'd rather quickly improve it rather than go through review rounds. |
|
@casperisfine Sorry for not being more explicit about it, but I already submitted a follow-up PR that includes specs: #1831 |
|
Ah that great! |
This is already de facto spec as Unicorn, Puma, and Falcon implement it. The changes to SPEC are compatible with both implementations. Fixes rack#1692 Fixes rack#1695 Co-authored-by: Jeremy Evans <[email protected]>
This is already de facto spec as Unicorn, Puma, and Falcon implement it. The changes to SPEC are compatible with both implementations. Fixes rack#1692 Fixes rack#1695 Co-authored-by: Jeremy Evans <[email protected]>
This is already de facto spec as Unicorn, Puma, and Falcon implement it. The changes to SPEC are compatible with both implementations. Fixes rack#1692 Fixes rack#1695 Co-authored-by: Jeremy Evans <[email protected]>
This is already de facto spec as Unicorn, Puma, and Falcon implement it. The changes to SPEC are compatible with both implementations. Fixes #1692 Fixes #1695 Co-authored-by: Jeremy Evans <[email protected]>
4 participants
Fix: #1692
This is kind of a first stab, I'm not familiar enough with
Rack::Lintto understand exactly what's needed. Please let me know if there are specifications I missed, or if the main description should be improved.cc @jeremyevans