Fixing ReDoS in header parsing

tenderlove · tenderlove · commit e4c117749ba2 · 2024-02-21T11:07:52.000-08:00
Thanks svalkanov [CVE-2024-26146]
diff --git a/lib/rack/utils.rb b/lib/rack/utils.rb
@@ -142,8 +142,8 @@ def build_nested_query(value, prefix = nil)
     end
 
     def q_values(q_value_header)
-      q_value_header.to_s.split(/\s*,\s*/).map do |part|
-        value, parameters = part.split(/\s*;\s*/, 2)
+      q_value_header.to_s.split(',').map do |part|
+        value, parameters = part.split(';', 2).map(&:strip)
         quality = 1.0
         if parameters && (md = /\Aq=([\d.]+)/.match(parameters))
           quality = md[1].to_f
