fix(rules): Rearrange the not operator in binary expressions #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
The
notoperator has two variants. If used in front ofother operator it negates its evaluation.
If used in front of the binary expression, it negates
the entire expression. When not used adequately, it can
lead to issues, such as erroneous rule matching. To mitigate this misbehaviour, it is better to standardize the
usage of the
notoperator and if meant to solely negatethe result of the adjacent operator, use the
lhs not operator rhspattern.What type of change does this PR introduce?
/kind bug-fix (non-breaking change which fixes an issue)
Any specific area of the project related to this PR?
/area rules
Special notes for the reviewer
Does this PR introduce a user-facing change?