Skip to content

Conversation

@rabbitstack
Copy link
Owner

What is the purpose of this PR / why it is needed?

fmt.Sprintf exhibits poor performance, especially when used in hot paths. To overcome this deficiency, we use the StringBuilder for a more efficient string concatenation.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


Use the StringBuilder for a more efficient
string concatenation.
@rabbitstack rabbitstack force-pushed the more-efficient-expr-string-methods branch from 625f944 to 2d13f51 Compare December 23, 2024 09:10
@rabbitstack rabbitstack merged commit 913b71a into master Dec 23, 2024
8 checks passed
@rabbitstack rabbitstack deleted the more-efficient-expr-string-methods branch December 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants