chore(ps): Append/remove module by base address #404
Merged
+29
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbitstack
force-pushed
the
add-module-by-addr
branch
2 times, most recently
from
6b272e8 to
ac3775e
Compare
Instead of appending/removing the process modules by its image name, we're now using the module base address to determine if the module was already added. The same logic is used to remove the existing module.
rabbitstack
force-pushed
the
add-module-by-addr
branch
from
ac3775e to
af110e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
Instead of appending/removing the process modules
by their image name, we're now using the module base address to determine if it was already added. The same logic is used to remove the existing module.
What type of change does this PR introduce?
/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)
Any specific area of the project related to this PR?
/area other
Special notes for the reviewer
Does this PR introduce a user-facing change?