Skip to content

Remove ReturnListener in RpcClient#close()#1169

Merged
michaelklishin merged 1 commit intorabbitmq:mainfrom
JHahnHRO:main
Nov 25, 2023
Merged

Remove ReturnListener in RpcClient#close()#1169
michaelklishin merged 1 commit intorabbitmq:mainfrom
JHahnHRO:main

Conversation

@JHahnHRO
Copy link
Copy Markdown
Contributor

Proposed Changes

Remove the ReturnListener in RpcClient#close() that is added in the constructor.

Types of Changes

  • Bugfix (non-breaking change which fixes issue Memory leak in RpcClient #1168)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Further Comments

None.

@pivotal-cla
Copy link
Copy Markdown

@JHahnHRO Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@JHahnHRO
Copy link
Copy Markdown
Contributor Author

@pivotal-cla This is an Obvious Fix

@pivotal-cla
Copy link
Copy Markdown

@JHahnHRO This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@michaelklishin michaelklishin merged commit 00ef564 into rabbitmq:main Nov 25, 2023
@michaelklishin michaelklishin added this to the 5.21.0 milestone Nov 25, 2023
@michaelklishin
Copy link
Copy Markdown
Contributor

Backported to 5.x. Thank you, @JHahnHRO.

@acogoluegnes acogoluegnes changed the title cleanup ReturnListener in close() Remove ReturnListener in RpcClient#close() Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants