Support for Erlang INET configuration #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespace and Namespaces fields are deprecated. The recommendation is to use Options.Cache.Namespaces. Signed-off-by: Aitor Perez Cedres <[email protected]>
Included as well cosmetic changes, and removed some redundant code. Signed-off-by: Aitor Perez Cedres <[email protected]>
This is in the effort to support IPv6, and dual-stack IPv4-IPv6 Signed-off-by: Aitor Perez Cedres <[email protected]>
Signed-off-by: Aitor Perez Cedres <[email protected]>
|
Approved while pairing with Aitor, and tested on Kind. MERGE IT 👍 |
|
The check that failed is a system test on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Additional Context
Originally inspired by #1455. Main motivation is to ease the configuration of Erlang
to use IPv6
Local Testing
There are unit and integration tests. There are no system tests as IPv6 requires infrastructure
support for IPv6, which is not guaranteed.