Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumping client-go and kustomize versions #1436

Merged
merged 1 commit into from
Sep 12, 2023
Merged

bumping client-go and kustomize versions #1436

merged 1 commit into from
Sep 12, 2023

Conversation

DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented Aug 29, 2023 •
edited
Loading

This closes #

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

The kustomize update should solve the issues in #1433, #1435 and #1429
To upgrade kustomize it was necessary to bump client-go as well.

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@DanielePalaia
Copy link
Contributor Author

Hey @Zerpet it seems like the newest version of client-go 0.28.1 solved the issue we had when upgrading kustomize. What do you think?

@DanielePalaia DanielePalaia requested a review from Zerpet August 29, 2023 14:26
Zerpet
Zerpet approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! 🙌

@Zerpet Zerpet merged commit c217f79 into main Sep 12, 2023
@Zerpet Zerpet deleted the bump_kustomize_version branch September 12, 2023 13:18
@DanielePalaia DanielePalaia mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zerpet Zerpet Zerpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielePalaia @Zerpet