Refactor Makefile #1432
Merged
Refactor Makefile #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerpet
force-pushed
the
refactor-makefile
branch
2 times, most recently
from
778aa1e to
0ad50a6
Compare
Some variables were mandatory for every target, even tho those were not used at all in most targets. For example, building the operator binary does not require information about the registry, yet, variables with information registry were checked and failed if not present. After this change, the variables are only checked in the targets relevant to those variables. For example, docker-push now checks that registry and operator image are set. It is no longer required to have all variables defined. The targets that make use of the variables will check and fail if variables are not set, with a relevant error message as of what target requires them. Signed-off-by: Aitor Pérez Cedres <[email protected]>
Zerpet
force-pushed
the
refactor-makefile
branch
from
0ad50a6 to
edcafed
Compare
MirahImage
approved these changes
Aug 24, 2023
DanielePalaia
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
Refactor makefile. Main change: stop checking for variables that are not needed in most targets.
Additional Context
Some variables were mandatory for every target, even tho those were not
used at all in most targets. For example, building the operator binary
does not require information about the registry, yet, variables with
information registry were checked and failed if not present.
After this change, the variables are only checked in the targets
relevant to those variables. For example, docker-push now checks that
registry and operator image are set.
It is no longer required to have all variables defined. The targets that
make use of the variables will check and fail if variables are not set,
with a relevant error message as of what target requires them.