Skip to content

fix: ask to execute deployment of contract in interactive flow #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Daanvdplas merged 1 commit into from
Nov 15, 2025
Merged

fix: ask to execute deployment of contract in interactive flow #759

Daanvdplas merged 1 commit into from
Nov 15, 2025

Conversation

@Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Nov 14, 2025

Closes #758

@codecov
Copy link

codecov bot commented Nov 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.23%. Comparing base (879ab31) to head (5511df4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/contract.rs 0.00% 14 Missing ⚠️ 
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   76.27%   76.23%   -0.05%     
==========================================
  Files         115      115              
  Lines       25991    26005      +14     
  Branches    25991    26005      +14     
==========================================
  Hits        19824    19824              
- Misses       4029     4043      +14     
  Partials     2138     2138
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/up/contract.rs 15.47% <0.00%> (-0.56%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AlexD10S
AlexD10S approved these changes Nov 15, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Daanvdplas Daanvdplas merged commit 5458da3 into main Nov 15, 2025
19 checks passed
@Daanvdplas Daanvdplas deleted the daan/fix-pop_up_contract_dry_run_interactive branch November 15, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pop up flow small bug

3 participants

@Daanvdplas @AlexD10S