fix: remove --manual-weight flag #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moliholy
force-pushed
the
fix/remove-manual-weight
branch
2 times, most recently
from
58d1bf2 to
9778520
Compare
moliholy
force-pushed
the
fix/remove-manual-weight
branch
from
9778520 to
a6a247d
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 76.33% 76.32% -0.02%
==========================================
Files 115 115
Lines 25990 25973 -17
Branches 25990 25973 -17
==========================================
- Hits 19840 19824 -16
+ Misses 4010 4008 -2
- Partials 2140 2141 +1
🚀 New features to boost your workflow:
|
AlexD10S
approved these changes
Nov 14, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Thanks for removing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738
This PR removes the
--manual-weightflag, which is inconsistent with thepop upflow.