Skip to content

feat: improve eth conversion #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 2 commits into from
Nov 13, 2025
Merged

feat: improve eth conversion #742

moliholy merged 2 commits into from
Nov 13, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Nov 13, 2025

This PR adds the following improvements to the Substrate <-> Ethereum address conversion:

  • Allows specifying a substrate address as raw 32-byte.
  • Removes the usage of SS58 prefix, as the whole ecosystem is already unified with prefix 0.
  • Transformes pure Substrate address (those that do have their last 12 bytes as 0xEE) in revive-compatible addresses.

@moliholy moliholy requested a review from AlexD10S November 13, 2025 13:30
@moliholy moliholy self-assigned this Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.28%. Comparing base (39ece66) to head (e9bad40).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/convert.rs 91.42% 1 Missing and 2 partials ⚠️ 
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   76.29%   76.28%   -0.01%     
==========================================
  Files         115      115              
  Lines       25908    25909       +1     
  Branches    25908    25909       +1     
==========================================
- Hits        19766    19765       -1     
  Misses       4015     4015              
- Partials     2127     2129       +2
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/mod.rs 66.50% <100.00%> (-0.50%) ⬇️
crates/pop-cli/src/commands/convert.rs 81.03% <91.42%> (-2.30%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AlexD10S
AlexD10S approved these changes Nov 13, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it, tested and works perfectly

@moliholy moliholy merged commit e42da43 into main Nov 13, 2025
19 checks passed
@moliholy moliholy deleted the feat/improve-eth-address-conversion branch November 13, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moliholy @AlexD10S