fix(install): Support more linux flavours based on already supported distros #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al3mart
changed the title
style: better comments
al3mart
force-pushed
the
al3mart/support-more-os
branch
from
439fb1e to
a4fc847
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 76.49% 76.36% -0.14%
==========================================
Files 115 115
Lines 25753 25857 +104
Branches 25753 25857 +104
==========================================
+ Hits 19700 19745 +45
- Misses 3937 3985 +48
- Partials 2116 2127 +11
🚀 New features to boost your workflow:
|
* fix: redhat installation * ci: run installation workflow for internal PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been throwing not supported errors on install for linux distros that we might in fact do support, only because the distro has a name X but is based on one of our supported OSs.
Meaning that we could have been using our already supported installation path for the distro the system running pop is based on.
After these changes if the linux OS is not one of:
Arch,Debian,RedhatorUbuntu. We will look for one of the following files:/etc/os-releaseor/usr/lib/os-releaseand parse it.The file includes information about the system. It will include between other fields:
NAMEIDID_LIKEAnd it is
ID_LIKEthat we will be using to implement the fix. If it contains information, it will give us OS identifiers that we could use to match against the initial list of OSs and run the proper installation.So in a scenario with a system like:
we would have normally returned an error prompting the OS is not compatible. With this fix in place this will install all dependencies just fine.
source: https://www.freedesktop.org/software/systemd/man/latest/os-release.html