feat: add ink-node to pop up #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moliholy
force-pushed
the
feat/ink-node-bootstrap
branch
from
f50861b to
cbf7f86
Compare
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 76.36% 76.29% -0.07%
==========================================
Files 115 115
Lines 25857 25908 +51
Branches 25857 25908 +51
==========================================
+ Hits 19745 19766 +21
- Misses 3985 4015 +30
Partials 2127 2127
🚀 New features to boost your workflow:
|
moliholy
force-pushed
the
feat/ink-node-bootstrap
branch
from
d9f549c to
f13ad69
Compare
al3mart
requested changes
Nov 12, 2025
Member
al3mart
left a comment
al3mart
left a comment
There was a problem hiding this comment.
It seems we are leaking the node logs into the terminal:
┌ Pop CLI : Launch a local Ink! node
│
▲ ⚠ The ink-node binary is not found.
│
◇ 📦 Would you like to source it automatically now?
│ Yes
│
⚙ Local node started successfully:
│ portal: https://polkadot.js.org/apps/?rpc=ws://localhost:9944/#/explorer
│ logs: tail -f /tmp/.tmpXz104M
│
⚙ Ethereum RPC node started successfully:
│ url: ws://localhost:8545
│ logs: tail -f /tmp/.tmpLZvMEc
│
2025-11-12 15:53:30.794 INFO main sc_basic_authorship::basic_authorship: 🙌 Starting consensus session on top of parent 0xf66b2697e7d2e491d9162c8de9dbdd8293d44870fb82c18e3a3bb2f891ae3b9f (#0)
2025-11-12 15:53:30.795 INFO tokio-runtime-worker sc_basic_authorship::basic_authorship: 🎁 Prepared block for proposing at 1 (1 ms) hash: 0x1013c318f22cc3de5e92ace11d39b1679e7a3c4a4c017e43b80a5e25943eae4a; parent_hash: 0xf66b…3b9f; end: NoMoreTransactions; extrinsics_count: 1
2025-11-12 15:53:30.796 INFO main sc_consensus_manual_seal::rpc: Consensus with no RPC sender success: CreatedBlock { hash: 0x1013c318f22cc3de5e92ace11d39b1679e7a3c4a4c017e43b80a5e25943eae4a, aux: ImportedAux { header_only: false, clear_justification_requests: false, needs_justification: false, bad_justification: false, is_new_best: true }, proof_size: 0 }
2025-11-12 15:53:30.796 INFO tokio-runtime-worker substrate: 🏆 Imported #1 (0xf66b…3b9f → 0x1013…ae4a)
2025-11-12 15:53:30.796 INFO tokio-runtime-worker txpool: maintain txs=(0, 0) a=1 i=0 views=[(1, 0, 0)] event=Finalized { hash: 0x1013c318f22cc3de5e92ace11d39b1679e7a3c4a4c017e43b80a5e25943eae4a, tree_route: [] } duration=228.662µs
2025-11-12 15:53:31.264 WARN tokio-runtime-worker libp2p_kad::behaviour: Failed to trigger bootstrap: No known peers.
2025-11-12 15:53:35.795 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #1 (0x1013…ae4a), finalized #1 (0x1013…ae4a), ⬇ 0 ⬆ 0
2025-11-12 15:53:40.796 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #1 (0x1013…ae4a), finalized #1 (0x1013…ae4a), ⬇ 0 ⬆ 0
2025-11-12 15:53:45.797 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #1 (0x1013…ae4a), finalized #1 (0x1013…ae4a), ⬇ 0 ⬆ 0
2025-11-12 15:53:49.275 INFO tokio-runtime-worker sc_basic_authorship::basic_authorship: 🙌 Starting consensus session on top of parent 0x1013c318f22cc3de5e92ace11d39b1679e7a3c4a4c017e43b80a5e25943eae4a (#1)
2025-11-12 15:53:49.278 INFO tokio-runtime-worker sc_basic_authorship::basic_authorship: 🎁 Prepared block for proposing at 2 (2 ms) hash: 0xe85280724c5017fff6f115b0faecdd1e2083426ec994c97d48545c70703f5bfc; parent_hash: 0x1013…ae4a; end: NoMoreTransactions; extrinsics_count: 2
2025-11-12 15:53:49.278 INFO tokio-runtime-worker sc_consensus_manual_seal::rpc: Consensus with no RPC sender success: CreatedBlock { hash: 0xe85280724c5017fff6f115b0faecdd1e2083426ec994c97d48545c70703f5bfc, aux: ImportedAux { header_only: false, clear_justification_requests: false, needs_justification: false, bad_justification: false, is_new_best: true }, proof_size: 0 }
2025-11-12 15:53:49.278 INFO tokio-runtime-worker substrate: 🏆 Imported #2 (0x1013…ae4a → 0xe852…5bfc)
2025-11-12 15:53:49.279 INFO tokio-runtime-worker txpool: maintain txs=(0, 1) a=1 i=1 views=[(2, 0, 0)] event=NewBestBlock { hash: 0xe85280724c5017fff6f115b0faecdd1e2083426ec994c97d48545c70703f5bfc, tree_route: None } duration=825.961µs
2025-11-12 15:53:50.279 INFO tokio-runtime-worker sc_consensus_manual_seal::finalize_block: ✅ Successfully finalized block: 0xe852…5bfc
2025-11-12 15:53:50.280 INFO tokio-runtime-worker sc_consensus_manual_seal::rpc: Consensus with no RPC sender success: ()
2025-11-12 15:53:50.280 INFO tokio-runtime-worker txpool: maintain txs=(0, 0) a=1 i=0 views=[(2, 0, 0)] event=Finalized { hash: 0xe85280724c5017fff6f115b0faecdd1e2083426ec994c97d48545c70703f5bfc, tree_route: [] } duration=111.238µs
2025-11-12 15:53:50.798 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #2 (0xe852…5bfc), finalized #2 (0xe852…5bfc), ⬇ 0 ⬆ 0
2025-11-12 15:53:55.799 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #2 (0xe852…5bfc), finalized #2 (0xe852…5bfc), ⬇ 0 ⬆ 0
2025-11-12 15:54:00.800 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #2 (0xe852…5bfc), finalized #2 (0xe852…5bfc), ⬇ 0 ⬆ 0
2025-11-12 15:54:05.801 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #2 (0xe852…5bfc), finalized #2 (0xe852…5bfc), ⬇ 0 ⬆ 0
2025-11-12 15:54:10.801 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #2 (0xe852…5bfc), finalized #2 (0xe852…5bfc), ⬇ 0 ⬆ 0
2025-11-12 15:54:15.802 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #2 (0xe852…5bfc), finalized #2 (0xe852…5bfc), ⬇ 0 ⬆ 0
2025-11-12 15:54:20.802 INFO tokio-runtime-worker substrate: 💤 Idle (0 peers), best: #2 (0xe852…5bfc), finalized #2 (0xe852…5bfc), ⬇ 0 ⬆ 0
^CSorry if this is of not much help. Wanted to fit a quick review of this asap anyway
Collaborator
Author
|
@al3mart yes, that's exactly the idea. Not saying that's the way to go, just one I thought could be interesting. |
Member
|
Ah, sorry @moliholy I didn't realised! I think I'd less problems with this if we were to always keep: on the top of the terminal. Right now the logs will bury that useful info. |
Collaborator
Author
|
@al3mart changed! |
moliholy
force-pushed
the
feat/ink-node-bootstrap
branch
from
039e5a8 to
65ca3b8
Compare
al3mart
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the following:
So that
ink-nodeandeth-rpcprocesses are started. The command allows configuring ports for both processes: