fix: remove chain spec generator for newer versions of templates #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moliholy
approved these changes
Nov 11, 2025
Collaborator
moliholy
left a comment
moliholy
left a comment
There was a problem hiding this comment.
LGTM! I still don't get how tests could have passed 🤔
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #727 +/- ##
==========================================
- Coverage 77.05% 77.04% -0.01%
==========================================
Files 111 111
Lines 25422 25433 +11
Branches 25422 25433 +11
==========================================
+ Hits 19589 19595 +6
- Misses 3772 3773 +1
- Partials 2061 2065 +4
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue in tests in some PRs https://github.com/r0gue-io/pop-cli/actions/runs/19237813604/job/54998530050 Investigating i see we where trying to generate the chain spec in the node folder but new versions of the templates don't have this folder.