Skip to content

feat: rich info for telemetry #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 6 commits into from
Nov 9, 2025
Merged

feat: rich info for telemetry #723

moliholy merged 6 commits into from
Nov 9, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Nov 6, 2025

This PR allows telemetry to have very complete data of all commands being used by serializing as JSON the commands being run, even at the end of the workflow when they have already been populated in case the user did not specify all possible parameters.

Sensitive data has been excluded from this serialization.

Screenshot

Statistics will look like this from now on:

Screenshot 2025-11-06 at 18 23 27

@moliholy moliholy requested review from AlexD10S and peterwht November 6, 2025 17:34
@moliholy moliholy self-assigned this Nov 6, 2025
@moliholy moliholy force-pushed the feat/complete-telemetry-data branch 2 times, most recently from b5bd769 to 3bbe531 Compare November 6, 2025 18:35
@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.31707% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.05%. Comparing base (f05fd7c) to head (45e5e9b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/mod.rs 0.00% 12 Missing ⚠️
crates/pop-cli/src/commands/build/mod.rs 59.09% 9 Missing ⚠️
crates/pop-cli/src/commands/bench/mod.rs 0.00% 7 Missing ⚠️
crates/pop-cli/src/commands/up/mod.rs 22.22% 3 Missing and 4 partials ⚠️
crates/pop-cli/src/commands/test/mod.rs 25.00% 4 Missing and 2 partials ⚠️
crates/pop-cli/src/commands/build/spec.rs 85.71% 2 Missing and 3 partials ⚠️
crates/pop-cli/src/commands/up/contract.rs 0.00% 4 Missing ⚠️
crates/pop-cli/src/commands/test/contract.rs 0.00% 3 Missing ⚠️
crates/pop-cli/src/main.rs 0.00% 3 Missing ⚠️
crates/pop-cli/src/commands/new/contract.rs 84.61% 1 Missing and 1 partial ⚠️
... and 10 more 
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   77.04%   77.05%   +0.01%     
==========================================
  Files         111      111              
  Lines       25418    25422       +4     
  Branches    25418    25422       +4     
==========================================
+ Hits        19583    19589       +6     
+ Misses       3774     3772       -2     
  Partials     2061     2061
Files with missing lines Coverage Δ
crates/pop-chains/src/build/mod.rs 85.00% <100.00%> (-0.02%) ⬇️
crates/pop-chains/src/templates.rs 99.61% <ø> (ø)
...es/pop-chains/src/try_runtime/shared_parameters.rs 100.00% <ø> (ø)
crates/pop-cli/src/commands/bench/block.rs 42.62% <ø> (ø)
crates/pop-cli/src/commands/bench/machine.rs 41.93% <ø> (ø)
crates/pop-cli/src/commands/bench/overhead.rs 43.47% <ø> (ø)
crates/pop-cli/src/commands/bench/storage.rs 67.00% <ø> (ø)
crates/pop-cli/src/commands/build/chain.rs 73.12% <100.00%> (ø)
crates/pop-cli/src/commands/build/runtime.rs 70.83% <100.00%> (ø)
crates/pop-cli/src/commands/call/chain.rs 68.21% <ø> (ø)
... and 31 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

peterwht
peterwht approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

For transparency: I did not do a very detailed review. Each change seemed reasonable and doesn't seem risky.

@AlexD10S AlexD10S requested a review from Daanvdplas November 7, 2025 08:14
@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Nov 7, 2025

Not sure if you have the time but if it is easy, can you look at #635 for additional things?

@moliholy moliholy force-pushed the feat/complete-telemetry-data branch from 43d9c6e to 45e5e9b Compare November 7, 2025 12:27
@moliholy
Copy link
Collaborator Author

moliholy commented Nov 7, 2025

Not sure if you have the time but if it is easy, can you look at #635 for additional things?

@Daanvdplas yes, that enhances tests for telemetry. Could be a good addition.

AlexD10S
AlexD10S approved these changes Nov 9, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see some clone() included, but I understand the reason behind it

@moliholy moliholy merged commit 1cb33ab into main Nov 9, 2025
26 of 28 checks passed
@moliholy moliholy deleted the feat/complete-telemetry-data branch November 9, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

@peterwht peterwht peterwht approved these changes

@Daanvdplas Daanvdplas Awaiting requested review from Daanvdplas

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@moliholy @Daanvdplas @AlexD10S @peterwht