Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Nov 5, 2025

This PR fixes the data field in the JSON payload, which must be an object and not a string. Since I was on it, I also improved debug logs for telemetry.

@moliholy moliholy requested a review from peterwht November 5, 2025 23:41
@moliholy moliholy self-assigned this Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.92%. Comparing base (565e5f0) to head (7d9044c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-telemetry/src/lib.rs 61.11% 4 Missing and 3 partials ⚠️
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   76.92%   76.92%   -0.01%     
==========================================
  Files         111      111              
  Lines       25234    25239       +5     
  Branches    25234    25239       +5     
==========================================
+ Hits        19412    19414       +2     
- Misses       3763     3767       +4     
+ Partials     2059     2058       -1     
Files with missing lines Coverage Δ
crates/pop-telemetry/src/lib.rs 85.85% <61.11%> (-1.19%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy merged commit d6611a4 into main Nov 6, 2025
19 checks passed
@moliholy moliholy deleted the feat/telemetry-log-command branch November 6, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants