feat: remove network configuration from base-parachain #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moliholy
force-pushed
the
feat/remove-base-parachain-network-config
branch
from
5762fa0 to
35a98e6
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 76.92% 76.96% +0.04%
==========================================
Files 111 111
Lines 25240 25251 +11
Branches 25240 25251 +11
==========================================
+ Hits 19415 19434 +19
+ Misses 3767 3761 -6
+ Partials 2058 2056 -2
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
AlexD10S
requested changes
Nov 5, 2025
moliholy
force-pushed
the
feat/remove-base-parachain-network-config
branch
from
35a98e6 to
7386dec
Compare
AlexD10S
approved these changes
Nov 6, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the 'workaround' checking the version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in r0gue-io/base-parachain#69 (review), this PR removes the
network.tomlfile from the base-parachain template.