Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Nov 2, 2025

This PR removes deprecated templates. They were meant to be removed in pop v0.11.0.

@moliholy moliholy requested a review from AlexD10S November 2, 2025 13:21
@moliholy moliholy self-assigned this Nov 2, 2025
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.92%. Comparing base (80a4c31) to head (f1d701b).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
- Coverage   76.92%   76.92%   -0.01%     
==========================================
  Files         111      111              
  Lines       25244    25234      -10     
  Branches    25244    25234      -10     
==========================================
- Hits        19420    19410      -10     
  Misses       3764     3764              
  Partials     2060     2060              
Files with missing lines Coverage Δ
crates/pop-chains/src/templates.rs 99.61% <100.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We usually remove deprecated features in the same PR as the release, but this approach is better because it ensures it will automatically be added in the CHANGELOG.

@moliholy moliholy merged commit 2dab6d6 into main Nov 3, 2025
19 checks passed
@moliholy moliholy deleted the feat/remove-deprecated-templates branch November 3, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants