Skip to content

feat: add eth-rpc binary to pop up contract #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 6 commits into from
Nov 1, 2025
Merged

feat: add eth-rpc binary to pop up contract #705

moliholy merged 6 commits into from
Nov 1, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Oct 31, 2025 •
edited
Loading

Closes #551.

This PR:

  • Adds eth-rpc to pop up contract workflow to enable Ethereum RPC compatibility.
  • Fixes a test that was very conflictive and took me quite some time to debug.
  • Removes some unused dependencies I found.

Screenshots

Screenshot 2025-11-01 at 01 39 01

@moliholy moliholy requested a review from AlexD10S October 31, 2025 16:00
@moliholy moliholy self-assigned this Oct 31, 2025
@moliholy moliholy force-pushed the feat/eth-rpc branch 6 times, most recently from e2e7a1d to a311e42 Compare October 31, 2025 23:18
@codecov
Copy link

codecov bot commented Oct 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 54.95868% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.99%. Comparing base (726b77b) to head (0cd3af9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/contract.rs 0.00% 38 Missing ⚠️
crates/pop-cli/src/common/contracts.rs 43.18% 6 Missing and 19 partials ⚠️
crates/pop-chains/src/up/mod.rs 69.56% 0 Missing and 14 partials ⚠️
crates/pop-common/src/helpers.rs 75.43% 0 Missing and 14 partials ⚠️
crates/pop-contracts/src/node.rs 78.00% 2 Missing and 9 partials ⚠️
crates/pop-cli/src/commands/test/contract.rs 0.00% 7 Missing ⚠️ 
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   77.04%   76.99%   -0.05%     
==========================================
  Files         111      111              
  Lines       25229    25357     +128     
  Branches    25229    25357     +128     
==========================================
+ Hits        19438    19524      +86     
- Misses       3745     3765      +20     
- Partials     2046     2068      +22
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/bench/pallet.rs 71.71% <ø> (ø)
crates/pop-cli/src/commands/call/mod.rs 85.54% <ø> (ø)
crates/pop-cli/src/common/helpers.rs 83.33% <ø> (+2.38%) ⬆️
crates/pop-cli/src/commands/test/contract.rs 0.00% <0.00%> (ø)
crates/pop-contracts/src/node.rs 79.22% <78.00%> (+2.42%) ⬆️
crates/pop-chains/src/up/mod.rs 87.21% <69.56%> (+0.03%) ⬆️
crates/pop-common/src/helpers.rs 81.57% <75.43%> (-6.15%) ⬇️
crates/pop-cli/src/common/contracts.rs 71.42% <43.18%> (-4.00%) ⬇️
crates/pop-cli/src/commands/up/contract.rs 13.97% <0.00%> (-0.74%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy changed the title feat: add eth-rpc binary feat: add eth-rpc binary to pop up contract Nov 1, 2025
AlexD10S
AlexD10S approved these changes Nov 1, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!
If users are only working with ink! metadata, they don’t actually need the eth-rpc, but probably your approach to have both running by default anyway is a better approach.

I’m also thinking we should to create a new issue to allow running eth-rpc not only with ink-node, but also with other nodes, for example, Paseo Asset Hub when running pop up paseo.
Thanks also for the cleaning removing unused dependencies.

@moliholy moliholy merged commit 6df01a9 into main Nov 1, 2025
23 of 24 checks passed
@moliholy moliholy deleted the feat/eth-rpc branch November 1, 2025 16:23
@moliholy
Copy link
Collaborator Author

moliholy commented Nov 1, 2025

I’m also thinking we should to create a new issue to allow running eth-rpc not only with ink-node, but also with other nodes, for example, Paseo Asset Hub when running pop up paseo.

That sounds like a great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support running contracts node without deploying a contract + add ETH-RPC flag

3 participants

@moliholy @AlexD10S