Skip to content

fix: StripPrefixError contract and pallet creation #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Daanvdplas merged 2 commits into from
Oct 31, 2025
Merged

fix: StripPrefixError contract and pallet creation #702

Daanvdplas merged 2 commits into from
Oct 31, 2025

Conversation

@Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Oct 30, 2025 •
edited
Loading

Fixes a bug I encountered for contract and also pallet creation: pop new contract flipper <flags>

Screenshot 2025-10-30 at 17 05 20

tsenovilla
tsenovilla approved these changes Oct 30, 2025
View reviewed changes
Copy link
Collaborator

@tsenovilla tsenovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx!

@codecov
Copy link

codecov bot commented Oct 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 61.66667% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.04%. Comparing base (2ecdda1) to head (3d589d6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/new/contract.rs 58.62% 4 Missing and 8 partials ⚠️
crates/pop-cli/src/commands/new/pallet.rs 64.51% 3 Missing and 8 partials ⚠️ 
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   77.06%   77.04%   -0.02%     
==========================================
  Files         111      111              
  Lines       25171    25229      +58     
  Branches    25171    25229      +58     
==========================================
+ Hits        19397    19438      +41     
- Misses       3741     3745       +4     
- Partials     2033     2046      +13
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/new/pallet.rs 79.38% <64.51%> (-0.50%) ⬇️
crates/pop-cli/src/commands/new/contract.rs 80.26% <58.62%> (-2.24%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AlexD10S
AlexD10S approved these changes Oct 30, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Daanvdplas Daanvdplas force-pushed the daan/fix-StripPrefixError branch from f97134d to 18c34f5 Compare October 31, 2025 13:19
@Daanvdplas Daanvdplas merged commit 726b77b into main Oct 31, 2025
19 checks passed
@Daanvdplas Daanvdplas deleted the daan/fix-StripPrefixError branch October 31, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

@tsenovilla tsenovilla tsenovilla approved these changes

@moliholy moliholy Awaiting requested review from moliholy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Daanvdplas @AlexD10S @tsenovilla