feat: pop up chain spec cmd #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moliholy
force-pushed
the
feat/pop-up-chain-spec-cmd
branch
from
0887a52 to
ab71b5b
Compare
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #699 +/- ##
==========================================
+ Coverage 77.06% 77.10% +0.04%
==========================================
Files 109 109
Lines 24669 24753 +84
Branches 24669 24753 +84
==========================================
+ Hits 19011 19087 +76
- Misses 3656 3663 +7
- Partials 2002 2003 +1
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the zombienet SDK from version 0.3.1 to 0.4.1, along with associated dependency updates (notably subxt 0.38.1 to 0.44.0, polkavm, cranelift, and various substrate primitives). Key changes include:
- Zombienet SDK and configuration bumped to 0.4.1
- API changes for zombienet methods (
.with_node→.with_validator,.wait_client()→.ws_uri()) raw_chain_specchanged fromPathBuftoOption<PathBuf>inGenesisArtifacts- Network configuration command-line argument changed from optional to required
- Added
--rawflag to build spec command - Various refactorings for consistency (e.g.,
std::fs→fs,anyhow::Result→Result)
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml / Cargo.lock | Upgrades zombienet-configuration and zombienet-sdk from 0.3.1 to 0.4.1, plus transitive dependency updates |
| crates/pop-cli/src/commands/build/spec.rs | Makes raw_chain_spec optional, adds --raw flag, conditional generation logic |
| crates/pop-cli/src/commands/up/network.rs | Simplifies command by making path required, removes deprecated file argument, adds cd_into_chain_base_dir helper |
| crates/pop-cli/src/commands/up/mod.rs | Updates to use required path parameter |
| crates/pop-cli/src/commands/up/rollup.rs | Return type cleanup, uses fs instead of std::fs |
| crates/pop-cli/src/deployment_api.rs | Adapts to Option<PathBuf> for raw_chain_spec |
| crates/pop-chains/src/relay.rs | Refactors clear_dmpq to accept endpoint string and create client internally |
| crates/pop-chains/src/up/mod.rs | Updates zombienet API calls: .with_node → .with_validator, adds chain spec command output path support |
| crates/pop-contracts/src/node.rs | Consolidates feature flag checks |
| crates/pop-telemetry/Cargo.toml | Formatting fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Collaborator
Author
|
@Daanvdplas just added two extra tests right now, as the coverage was low. Mind to re-approve? |
Daanvdplas
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
--rawflag topop build specto build the raw chain spec.All these changes are related to adding support for omni-node-based chains.