feat: force specifying storage parameters if the key is composite #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 77.06% 77.06% -0.01%
==========================================
Files 109 109
Lines 24667 24669 +2
Branches 24667 24669 +2
==========================================
+ Hits 19010 19011 +1
- Misses 3654 3656 +2
+ Partials 2003 2002 -1
🚀 New features to boost your workflow:
|
moliholy
changed the title
AlexD10S
approved these changes
Oct 29, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
LGTM, this makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed by #696, I reliazed composite keys cannot be partially specified. This PR forces the user to specify them instead of raising an error when attempting to query an storage key that is not fully complete, yielding strange errors.
From DevEx perspective, it's hard to justify to the user why sometimes keys can be omitted and why sometimes they are mandatory, but I think it's better to at least let them know that they must specify the full key in this case.