fix: pop call with composite types #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moliholy
commented
Oct 28, 2025
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 76.89% 77.06% +0.16%
==========================================
Files 109 109
Lines 24635 24667 +32
Branches 24635 24667 +32
==========================================
+ Hits 18944 19010 +66
+ Misses 3702 3654 -48
- Partials 1989 2003 +14
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
moliholy
force-pushed
the
fix/pop-call-with-tuples
branch
from
0b1578b to
8f662d8
Compare
Collaborator
Author
|
@AlexD10S there's still an edge case: if the second parameter is not specified, it does not return anything. I believe this is expected, as the key is composite. Actually, polkadotjs does not return anything either. But of course this is subject to further discussion. |
moliholy
force-pushed
the
fix/pop-call-with-tuples
branch
from
673393e to
d2fa86f
Compare
moliholy
changed the title
moliholy
force-pushed
the
fix/pop-call-with-tuples
branch
from
513c9e7 to
9108ff9
Compare
AlexD10S
approved these changes
Oct 29, 2025
Collaborator
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Amazing!! Thanks for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #689.
This PR allows to properly query keys with composed types by transforming them into tuples.
You can test it out by running:
OR
OR
OR
And manually typing 1000 and 4566 as parameters.
Since I was on it, I also:
--skip-confirmflag, which is more specific.--skip-confirmindisplay().