Skip to content

feat: fetch polkadot-omni-node with pop up command #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moliholy merged 1 commit into from
Oct 22, 2025
Merged

feat: fetch polkadot-omni-node with pop up command #684

moliholy merged 1 commit into from
Oct 22, 2025

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Oct 20, 2025 •
edited
Loading

Closes #655

This PR:

  • Fetches the polkadot-omni-node binary when executing pop up.
  • Uses the recently fetched binary as the equivalent of a parachain node to run the network.

@moliholy moliholy self-assigned this Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.89474% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.95%. Comparing base (a4cd6a4) to head (487520c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-chains/src/omni_node.rs 86.41% 1 Missing and 10 partials ⚠️
crates/pop-chains/src/up/mod.rs 16.66% 10 Missing ⚠️ 
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   76.98%   76.95%   -0.03%     
==========================================
  Files         108      109       +1     
  Lines       24597    24609      +12     
  Branches    24597    24609      +12     
==========================================
+ Hits        18935    18937       +2     
- Misses       3680     3690      +10     
  Partials     1982     1982
Files with missing lines Coverage Δ
crates/pop-chains/src/lib.rs 0.00% <ø> (ø)
crates/pop-cli/src/common/bench.rs 81.56% <ø> (ø)
crates/pop-cli/src/common/binary.rs 72.65% <100.00%> (ø)
crates/pop-cli/src/common/contracts.rs 83.33% <ø> (ø)
crates/pop-cli/src/common/mod.rs 100.00% <ø> (ø)
crates/pop-cli/src/common/omni_node.rs 91.30% <ø> (+3.11%) ⬆️
crates/pop-cli/src/common/try_runtime.rs 91.05% <ø> (ø)
crates/pop-chains/src/up/mod.rs 87.44% <16.66%> (-0.37%) ⬇️
crates/pop-chains/src/omni_node.rs 86.41% <86.41%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy force-pushed the feat/pop-up-omni-node branch from 93dd4c5 to b27213e Compare October 20, 2025 11:43
@moliholy moliholy force-pushed the feat/pop-up-omni-node branch from b27213e to 487520c Compare October 20, 2025 13:33
AlexD10S
AlexD10S approved these changes Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moliholy moliholy merged commit d1fd257 into main Oct 22, 2025
19 checks passed
@moliholy moliholy deleted the feat/pop-up-omni-node branch October 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexD10S AlexD10S AlexD10S approved these changes

@al3mart al3mart Awaiting requested review from al3mart

@tsenovilla tsenovilla Awaiting requested review from tsenovilla

Assignees

@moliholy moliholy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make pop up network compatible with parachains without node

3 participants

@moliholy @AlexD10S