fix: pop install command with rustup
#681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #683.
This PR fixes the installation code by polishing how rustup is installed:
I confirm the whole flow has been successfully tested in a docker with
ubuntu:latestby running the following commands:In normal conditions we'd run
brew install r0gue-io/pop-cli/pop(which yes, works on linux systems too) instead of copying it, but I already had the pop binary compiled for ubuntu in order to test the installation script with my local code.