Skip to content

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Oct 17, 2025

Closes #683.

This PR fixes the installation code by polishing how rustup is installed:

  • Making debian packages installation non-interactive by setting the corresponding environment variables.
  • Fixing the rustup installation, which was broken in case rustup was not previously installed (which was never checked since in the CI we always installed previously rustup).

I confirm the whole flow has been successfully tested in a docker with ubuntu:latest by running the following commands:

export NONINTERACTIVE=1 && \
export DEBIAN_FRONTEND=noninteractive && \
apt-get update && \
apt-get install git curl gcc build-essential -y && \
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" && \
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" \
cp /workdir/target/debug/pop /usr/local/bin &&
pop --version && \
unset DEBIAN_FRONTEND && \
pop install -y

In normal conditions we'd run brew install r0gue-io/pop-cli/pop (which yes, works on linux systems too) instead of copying it, but I already had the pop binary compiled for ubuntu in order to test the installation script with my local code.

@moliholy moliholy self-assigned this Oct 17, 2025
@moliholy moliholy force-pushed the feat/install-silently branch from a49e928 to 5b6d9f6 Compare October 17, 2025 17:44
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.98%. Comparing base (b0a49ff) to head (a50bfbc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/install/mod.rs 0.00% 16 Missing ⚠️
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   76.99%   76.98%   -0.02%     
==========================================
  Files         108      108              
  Lines       24592    24597       +5     
  Branches    24592    24597       +5     
==========================================
  Hits        18935    18935              
- Misses       3675     3680       +5     
  Partials     1982     1982              
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/install/mod.rs 41.72% <0.00%> (-0.74%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@moliholy moliholy changed the title feat(cli): install silently fix: pop install command with rustup Oct 20, 2025
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moliholy moliholy merged commit a4cd6a4 into main Oct 20, 2025
24 checks passed
@moliholy moliholy deleted the feat/install-silently branch October 20, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve pop install command

3 participants